Re: [PATCH 1/1] cxgb3i: Fix a login over vlan issue

Rakesh Ranjan
2009-12-10T13:46:12Z

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Patrick McHardy wrote:
> kxie@chelsio.com wrote:
>> [PATCH 1/1] cxgb3i: Fix a login over vlan issue
>>
>> From: Karen Xie <kxie@chelsio.com>
>>
>> Fix a login over vlan issue, when parent interface is vlan and we are using
>>
>> cxgb3i sepecific private ip address in '/etc/iscsi/ifaces/' iface file.
>>
>> +/**
>> + * cxgb3i_find_dev - find the interface associated with the given address
>> + * @ipaddr: ip address
>> + */
>> +static struct net_device *cxgb3i_find_dev(__be32 ipaddr)
>> +{
>> + struct flowi fl;
>> + int err;
>> + struct rtable *rt;
>> +
>> + memset(&fl, 0, sizeof(fl));
>> + fl.nl_u.ip4_u.daddr = ipaddr;
>> +
>> + err = ip_route_output_key(&init_net, &rt, &fl);
>> + if (!err)
>> + return (&rt->u.dst)->dev;
>> +
>> + return NULL;
>> +}
>
> This probably shouldn't be using init_net but the current namespace.

Hi Patrick,

Thanks for review, will fix that and send another path shortly.

Regards
Rakesh Ranjan

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 898 bytes --]