linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment
@ 2009-12-04 19:43 Bart Van Assche
  2010-01-04 16:19 ` Bart Van Assche
  2010-01-04 18:57 ` Brian King
  0 siblings, 2 replies; 4+ messages in thread
From: Bart Van Assche @ 2009-12-04 19:43 UTC (permalink / raw)
  To: linux-scsi, Brian King; +Cc: James E.J. Bottomley

Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>

diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index e475b79..e3a18e0 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -40,7 +40,7 @@
  * (CRQ), which is just a buffer of 16 byte entries in the receiver's 
  * Senders cannot access the buffer directly, but send messages by
  * making a hypervisor call and passing in the 16 bytes.  The hypervisor
- * puts the message in the next 16 byte space in round-robbin fashion,
+ * puts the message in the next 16 byte space in round-robin fashion,
  * turns on the high order bit of the message (the valid bit), and 
  * generates an interrupt to the receiver (if interrupts are turned on.) 
  * The receiver just turns off the valid bit when they have copied out

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment
  2009-12-04 19:43 [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment Bart Van Assche
@ 2010-01-04 16:19 ` Bart Van Assche
  2010-01-04 16:34   ` James Bottomley
  2010-01-04 18:57 ` Brian King
  1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2010-01-04 16:19 UTC (permalink / raw)
  To: James E.J. Bottomley; +Cc: linux-scsi, Brian King

On Fri, Dec 4, 2009 at 8:43 PM, Bart Van Assche
<bart.vanassche@gmail.com> wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index e475b79..e3a18e0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -40,7 +40,7 @@
>  * (CRQ), which is just a buffer of 16 byte entries in the receiver's
>  * Senders cannot access the buffer directly, but send messages by
>  * making a hypervisor call and passing in the 16 bytes.  The hypervisor
> - * puts the message in the next 16 byte space in round-robbin fashion,
> + * puts the message in the next 16 byte space in round-robin fashion,
>  * turns on the high order bit of the message (the valid bit), and
>  * generates an interrupt to the receiver (if interrupts are turned on.)
>  * The receiver just turns off the valid bit when they have copied out

Hello James,

Does anyone have to ack this trivial patch before it can be added to
the scsi-misc-2.6.git repository ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment
  2010-01-04 16:19 ` Bart Van Assche
@ 2010-01-04 16:34   ` James Bottomley
  0 siblings, 0 replies; 4+ messages in thread
From: James Bottomley @ 2010-01-04 16:34 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: linux-scsi, Brian King

On Mon, 2010-01-04 at 17:19 +0100, Bart Van Assche wrote:
> On Fri, Dec 4, 2009 at 8:43 PM, Bart Van Assche
> <bart.vanassche@gmail.com> wrote:
> > Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
> >
> > diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> > index e475b79..e3a18e0 100644
> > --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> > +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> > @@ -40,7 +40,7 @@
> >  * (CRQ), which is just a buffer of 16 byte entries in the receiver's
> >  * Senders cannot access the buffer directly, but send messages by
> >  * making a hypervisor call and passing in the 16 bytes.  The hypervisor
> > - * puts the message in the next 16 byte space in round-robbin fashion,
> > + * puts the message in the next 16 byte space in round-robin fashion,
> >  * turns on the high order bit of the message (the valid bit), and
> >  * generates an interrupt to the receiver (if interrupts are turned on.)
> >  * The receiver just turns off the valid bit when they have copied out
> 
> Hello James,
> 
> Does anyone have to ack this trivial patch before it can be added to
> the scsi-misc-2.6.git repository ?

It's not required, but it does help.  All patches (however trivial) do
need reviewing before they go in.  My review fifo tends to be long, and
trivial stuff goes right at the end, so if someone else I trust (like
the maintainer) acks it, it can come out of my fifo and go into the
tree.

James



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment
  2009-12-04 19:43 [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment Bart Van Assche
  2010-01-04 16:19 ` Bart Van Assche
@ 2010-01-04 18:57 ` Brian King
  1 sibling, 0 replies; 4+ messages in thread
From: Brian King @ 2010-01-04 18:57 UTC (permalink / raw)
  To: Bart Van Assche; +Cc: linux-scsi, James E.J. Bottomley

Acked-by: Brian King <brking@linux.vnet.ibm.com>

On 12/04/2009 01:43 PM, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche@gmail.com>
> 
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
> index e475b79..e3a18e0 100644
> --- a/drivers/scsi/ibmvscsi/ibmvscsi.c
> +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
> @@ -40,7 +40,7 @@
>   * (CRQ), which is just a buffer of 16 byte entries in the receiver's 
>   * Senders cannot access the buffer directly, but send messages by
>   * making a hypervisor call and passing in the 16 bytes.  The hypervisor
> - * puts the message in the next 16 byte space in round-robbin fashion,
> + * puts the message in the next 16 byte space in round-robin fashion,
>   * turns on the high order bit of the message (the valid bit), and 
>   * generates an interrupt to the receiver (if interrupts are turned on.) 
>   * The receiver just turns off the valid bit when they have copied out
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Brian King
Linux on Power Virtualization
IBM Linux Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-01-04 18:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-04 19:43 [PATCH] SCSI/ibmvscsi: fix a typo in a source code comment Bart Van Assche
2010-01-04 16:19 ` Bart Van Assche
2010-01-04 16:34   ` James Bottomley
2010-01-04 18:57 ` Brian King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).