public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Chandra Seetharaman <chandra.seetharaman@us.ibm.com>
Subject: Re: [dm-devel] [PATCH] dm-mpath: Fixing unnecessary argument casting
Date: Wed, 06 Jan 2010 10:38:33 +0900	[thread overview]
Message-ID: <4B43E999.70103@ct.jp.nec.com> (raw)
In-Reply-To: <E463DF2B2E584B4A82673F53D62C2EF4877BC84E@cosmail01.lsi.com>

Hi,

I have the exact same patch.

On 2010/01/06 3:39 +0900, Moger, Babu wrote:
> This patch removes couple of unnecessary argument casting. There is no functional change with this patch.
> Tested the changes with LSI storage..
> 
> CC: Chandra Seetharaman <chandra.seetharaman@us.ibm.com>
> Signed-off-by: Babu Moger <babu.moger@lsi.com>
> ---
> --- linux-2.6.33-rc2/drivers/md/dm-mpath.c.orig	2010-01-05 12:47:26.000000000 -0400
> +++ linux-2.6.33-rc2/drivers/md/dm-mpath.c	2010-01-05 12:34:00.000000000 -0400
> @@ -1128,8 +1128,7 @@ static int pg_init_limit_reached(struct
>  
>  static void pg_init_done(void *data, int errors)
>  {
> -	struct dm_path *path = data;
> -	struct pgpath *pgpath = path_to_pgpath(path);
> +	struct pgpath *pgpath = data;
>  	struct priority_group *pg = pgpath->pg;
>  	struct multipath *m = pg->m;
>  	unsigned long flags;
> @@ -1198,7 +1197,7 @@ static void activate_path(struct work_st
>  		container_of(work, struct pgpath, activate_path);
>  
>  	scsi_dh_activate(bdev_get_queue(pgpath->path.dev->bdev),
> -				pg_init_done, &pgpath->path);
> +				pg_init_done, pgpath);
>  }
>  
>  /*

Acked-by: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>

Thanks,
Kiyoshi Ueda

      reply	other threads:[~2010-01-06  1:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 18:39 [PATCH] dm-mpath: Fixing unnecessary argument casting Moger, Babu
2010-01-06  1:38 ` Kiyoshi Ueda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B43E999.70103@ct.jp.nec.com \
    --to=k-ueda@ct.jp.nec.com \
    --cc=chandra.seetharaman@us.ibm.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox