Re: [GIT PATCH] SCSI bug fixes for 2.6.33-rc3

[Boaz Harrosh <bharrosh@panasas.com>]

On 01/06/2010 07:02 PM, James Bottomley wrote:
> This patch represents the accumulated bug fixes in a variety of drivers,
> with concentrated bug fix updates for emulex NPIV and qla2xxx EEH.
> 

James you have missed a very serious fix to scsi_lib.
  http://www.spinics.net/lists/linux-scsi/msg41125.html

In Fedora12, if there is an iscsi device in the system, as a normal user
I can run a cooked up, push bidi commands via bsg program that can easily
crash the Kernel. It must be plugged. (Regardless if the target is not
bidi the command can error, it does not matter)

The fix itself is a one liner no brainer. Just use before you free.

Also needed by stable

Cheers
Boaz

> The patch is available at:
> 
> master.kernel.org:/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6.git
> 
> The short changelog is
> 
> Andrew Vasquez (1):
>       qla2xxx: Extend base EEH support in qla2xxx.
> 
> Anil Ravindranath (1):
>       pmcraid: fix to avoid twice scsi_dma_unmap for a command
> 
> Anirban Chakraborty (1):
>       qla2xxx: Fix for a multiqueue bug in CPU affinity mode
> 
> Duane Grigsby (1):
>       qla2xxx: Added to EEH support.
> 
> Ed Lin (1):
>       stex: fix scan of nonexistent lun
> 
> Giridhar Malavali (1):
>       qla2xxx: Update version number to 8.03.01-k9.
> 
> James Smart (6):
>       lpfc 8.3.7: Update Driver version to 8.3.7
>       lpfc 8.3.7: Fix discovery failures.
>       lpfc 8.3.7: Fix SCSI protocol related errors.
>       lpfc 8.3.7: Fix hardware/SLI relates issues
>       lpfc 8.3.7: Fix NPIV operation errors
>       lpfc 8.3.7: Fix FC protocol errors
> 
> Michael Hernandez (1):
>       qla2xxx: Get the link data rate explicitly during device resync.
> 
> Rakesh Ranjan (1):
>       cxgb3i: Fix a login over vlan issue
> 
> the diffstat
> 
>  drivers/scsi/cxgb3i/cxgb3i_offload.c |   34 ++++++++++++-
>  drivers/scsi/lpfc/lpfc_els.c         |    4 -
>  drivers/scsi/lpfc/lpfc_hbadisc.c     |   25 ++++++++-
>  drivers/scsi/lpfc/lpfc_hw4.h         |    3 -
>  drivers/scsi/lpfc/lpfc_init.c        |   14 ++++-
>  drivers/scsi/lpfc/lpfc_sli.c         |   48 +++++++++++-------
>  drivers/scsi/lpfc/lpfc_sli4.h        |    2 
>  drivers/scsi/lpfc/lpfc_version.h     |    2 
>  drivers/scsi/lpfc/lpfc_vport.c       |    4 +
>  drivers/scsi/pmcraid.c               |    8 +--
>  drivers/scsi/qla2xxx/qla_attr.c      |   32 ++++++++++--
>  drivers/scsi/qla2xxx/qla_dbg.h       |    9 +++
>  drivers/scsi/qla2xxx/qla_def.h       |    2 
>  drivers/scsi/qla2xxx/qla_gbl.h       |    1 
>  drivers/scsi/qla2xxx/qla_init.c      |   22 ++++++++
>  drivers/scsi/qla2xxx/qla_isr.c       |    9 ++-
>  drivers/scsi/qla2xxx/qla_mbx.c       |   64 +++++++++++++++++++++++-
>  drivers/scsi/qla2xxx/qla_mid.c       |    2 
>  drivers/scsi/qla2xxx/qla_os.c        |   90 +++++++++++++++++++++++++++++++----
>  drivers/scsi/qla2xxx/qla_version.h   |    2 
>  drivers/scsi/stex.c                  |    5 +
>  21 files changed, 322 insertions(+), 60 deletions(-)
> 
> Entire diff is below.
> 
> James
> 
<snip>