* [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr()
@ 2010-01-19 20:17 Roel Kluin
2010-01-22 1:59 ` Jing Huang
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-19 20:17 UTC (permalink / raw)
To: Jing Huang, linux-scsi, Andrew Morton, LKML
Compare it with the disable msgtag.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Was this maybe intended? otherwise in case BFI_PPORT_I2H_ENABLE_RSP:
the same code is executed. Please review.
diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
index aef648b..f00d07b 100644
--- a/drivers/scsi/bfa/bfa_fcport.c
+++ b/drivers/scsi/bfa/bfa_fcport.c
@@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s *msg)
break;
case BFI_PPORT_I2H_DISABLE_RSP:
- if (pport->msgtag == i2hmsg.enable_rsp->msgtag)
+ if (pport->msgtag == i2hmsg.disable_rsp->msgtag)
bfa_sm_send_event(pport, BFA_PPORT_SM_FWRSP);
break;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr()
2010-01-19 20:17 [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr() Roel Kluin
@ 2010-01-22 1:59 ` Jing Huang
0 siblings, 0 replies; 2+ messages in thread
From: Jing Huang @ 2010-01-22 1:59 UTC (permalink / raw)
To: Roel Kluin, linux-scsi@vger.kernel.org, Andrew Morton, LKML
Cc: Adapter Linux Open SRC Team
> Was this maybe intended? otherwise in case BFI_PPORT_I2H_ENABLE_RSP:
> the same code is executed. Please review.
Making this change alone will break compilation since bfa_pport_disable_rsp_s is not defined. To fix this, we should also replace it with bfa_pport_generic_rsp_s in bfi_pport_i2h_msg_u.
But please keep this as it is for now since I am working on resubmitting 2.1.2.1 patch, and there are a lot of changes in this area.
Thanks
Jing
>
> diff --git a/drivers/scsi/bfa/bfa_fcport.c b/drivers/scsi/bfa/bfa_fcport.c
> index aef648b..f00d07b 100644
> --- a/drivers/scsi/bfa/bfa_fcport.c
> +++ b/drivers/scsi/bfa/bfa_fcport.c
> @@ -918,7 +918,7 @@ bfa_pport_isr(struct bfa_s *bfa, struct bfi_msg_s
> *msg)
> break;
>
> case BFI_PPORT_I2H_DISABLE_RSP:
> - if (pport->msgtag == i2hmsg.enable_rsp->msgtag)
> + if (pport->msgtag == i2hmsg.disable_rsp->msgtag)
> bfa_sm_send_event(pport, BFA_PPORT_SM_FWRSP);
> break;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-22 1:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 20:17 [PATCH] bfa: comparison with wrong msgtag in bfa_pport_isr() Roel Kluin
2010-01-22 1:59 ` Jing Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox