From: James Smart <james.smart@emulex.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev()
Date: Tue, 19 Jan 2010 17:41:06 -0500 [thread overview]
Message-ID: <4B563502.6070908@emulex.com> (raw)
In-Reply-To: <4B5329AD.9010100@gmail.com>
Acked-by: James Smart <james.smart@emulex.com>
-- james s
Roel Kluin wrote:
> Regardless of the flag state, the branches execute the same code
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 0ebcd9b..bf7bf62 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -1843,12 +1843,7 @@ lpfc_decode_firmware_rev(struct lpfc_hba *phba, char *fwrevision, int flag)
> c = (rev & 0x0000ff00) >> 8;
> b4 = (rev & 0x000000ff);
>
> - if (flag)
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> - else
> - sprintf(fwrevision, "%d.%d%d%c%d ", b1,
> - b2, b3, c, b4);
> + sprintf(fwrevision, "%d.%d%d%c%d", b1, b2, b3, c, b4);
> }
> return;
> }
>
prev parent reply other threads:[~2010-01-19 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 15:15 [PATCH] lpfc: two branches the same in lpfc_decode_firmware_rev() Roel Kluin
2010-01-19 22:40 ` James Smart
2010-01-19 22:41 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B563502.6070908@emulex.com \
--to=james.smart@emulex.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox