* [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth()
@ 2010-01-29 10:25 Roel Kluin
2010-02-02 19:47 ` Giridhar Malavali
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-29 10:25 UTC (permalink / raw)
To: Andrew Vasquez, linux-driver, linux-scsi, Andrew Morton, LKML
The *change_queue_depth functions usually return a negative error return.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 8529eb1..0753877 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
break;
default:
- return EOPNOTSUPP;
+ return -EOPNOTSUPP;
}
return sdev->queue_depth;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth()
2010-01-29 10:25 [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth() Roel Kluin
@ 2010-02-02 19:47 ` Giridhar Malavali
0 siblings, 0 replies; 2+ messages in thread
From: Giridhar Malavali @ 2010-02-02 19:47 UTC (permalink / raw)
To: Roel Kluin
Cc: Andrew Vasquez, Linux Driver, linux-scsi@vger.kernel.org,
Andrew Morton, LKML
Acked-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
On Jan 29, 2010, at 2:25 AM, Roel Kluin wrote:
> The *change_queue_depth functions usually return a negative error
> return.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/
> qla_os.c
> index 8529eb1..0753877 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1258,7 +1258,7 @@ qla2x00_change_queue_depth(struct scsi_device
> *sdev, int qdepth, int reason)
> qla2x00_adjust_sdev_qdepth_up(sdev, qdepth);
> break;
> default:
> - return EOPNOTSUPP;
> + return -EOPNOTSUPP;
> }
>
> return sdev->queue_depth;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-02 19:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-29 10:25 [PATCH] qla2xxx: negative error return in qla2x00_change_queue_depth() Roel Kluin
2010-02-02 19:47 ` Giridhar Malavali
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).