public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "René Bolldorf" <xsecute@googlemail.com>
To: linux-scsi <linux-scsi@vger.kernel.org>
Subject: [Patch]: Enable SCSI Wait Scan only if BLK_DEV_INITRD is set.
Date: Mon, 22 Feb 2010 23:53:31 +0100	[thread overview]
Message-ID: <4B830AEB.3010905@googlemail.com> (raw)

Hi,

The scsi_wait_scan module should only be enabled if BLKD_DEV_INITRD is 
set. And i think it's better then the user can enable/disable the module 
of their own risk.

Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>

========================================================================

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 9191d1e..b785703 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -258,21 +258,22 @@ config SCSI_SCAN_ASYNC
  	  or async on the kernel's command line.

  config SCSI_WAIT_SCAN
-	tristate  # No prompt here, this is an invisible symbol.
+	tristate "SCSI Wait Scan"
  	default m
  	depends on SCSI
+	depends on SCSI_SCAN_ASYNC
  	depends on MODULES
-# scsi_wait_scan is a loadable module which waits until all the async 
scans are
-# complete.  The idea is to use it in initrd/ initramfs scripts.  You 
modprobe
-# it after all the modprobes of the root SCSI drivers and it will wait 
until
-# they have all finished scanning their buses before allowing the boot to
-# proceed.  (This method is not applicable if targets boot independently in
-# parallel with the initiator, or with transports with 
non-deterministic target
-# discovery schemes, or if a transport driver does not support 
scsi_wait_scan.)
-#
-# This symbol is not exposed as a prompt because little is to be gained by
-# disabling it, whereas people who accidentally switch it off may 
wonder why
-# their mkinitrd gets into trouble.
+	depends on BLK_DEV_INITRD
+	help
+	  scsi_wait_scan is a loadable module which waits until all the async 
scans are
+	  complete.  The idea is to use it in initrd/ initramfs scripts.  You 
modprobe
+	  it after all the modprobes of the root SCSI drivers and it will wait 
until
+	  they have all finished scanning their buses before allowing the boot to
+	  proceed.  (This method is not applicable if targets boot 
independently in
+	  parallel with the initiator, or with transports with 
non-deterministic target
+	  discovery schemes, or if a transport driver does not support 
scsi_wait_scan.)
+
+	  People that use a initramfs should say Y or M.

  menu "SCSI Transports"
  	depends on SCSI

             reply	other threads:[~2010-02-22 22:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-22 22:53 René Bolldorf [this message]
2010-02-23 16:08 ` [Patch]: Enable SCSI Wait Scan only if BLK_DEV_INITRD is set Stefan Richter
2010-02-23 18:57   ` René Bolldorf
2010-02-23 20:52     ` Joe Eykholt
2010-02-23 21:07       ` Stefan Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B830AEB.3010905@googlemail.com \
    --to=xsecute@googlemail.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox