Re: FW: [PATCH 2/2] RFC: The be2iscsi driver support for bsg

[Mike Christie <michaelc@cs.wisc.edu>]

On 03/19/2010 05:48 PM, Ravi Anand wrote:
>> On Thu, 18 Mar 2010 16:02:52 -0500
>> Mike Christie<michaelc@cs.wisc.edu>  wrote:
>>
>>> On 03/18/2010 08:58 AM, FUJITA Tomonori wrote:
>>>>
>>>> - You invent your hardware specific data structure for the simplest
>>>>     operation such as setting IP address.
>>>
>>> I think this is what Jay is not trying to do. I think the patch has some
>>> extra code like the ISCSI_BSG_HST_VENDOR parts that makes it confusing -
>>> it got me too. The ISCSI_BSG_HST_VENDOR code in be2iscsi looks like it
>>> is basically disabled (should remove for a formal patch when he sends
>>> for merging).
>>>
>>> It looks like there is a common struct iscsi_bsg_common_format that is
>>> getting passed around, and then in be2iscsi the driver is using that
>>> info to make a be2iscsi specific command. So scsi_transport_iscsi /
>>> ISCSI_SET_IP_ADDR / iscsi_bsg_common_format  gets translated by b2iscsi
>>> to b2iscsi / OPCODE_COMMON_ISCSI_NTWK_MODIFY_IP_ADDR / be_modify_ip_addr.
>>
>> Yeah, seems you are right. But looks like this patchset also adds the
>> vendor specific message support (ISCSI_BSG_HST_VENDOR)?
>>
.......

> Here's an early snapshot of the patch which we are working on to add
> the support using bsg vendor specific part - btw this is based on the previous
> iscsi bsg patch  and need to be synced up with what was posted recently.

Just to make sure we are all on the same page. Tomo's comments above 
means that for your comment about updating to the new code does not mean 
that you should just use the new HST_VENDOR cmd, and it does not mean 
that we only should use a common struct/cmd for net operations that Jay 
handled.

For other common operations we should do like Tomo suggested, and Jay 
started with the network stuff, and make common operations. You guys 
should also not feel like you have to use the format Jay posted with. We 
can modify it so it make sense for everyone.


> +	switch (msgcode) {
> +	case ISCSI_BSG_HST_VENDOR:
> +		rval = qla4xxx_process_vendor_specific(job);
> +		break;
> +	case ISCSI_BSG_HST_PING:
> +		rval = qla4xxx_ping(job);
> +		break;
> +	default:
> +		break;
> +	}
> +