* [PATCH 1/3] [BNX2I] instruct firmware to use driver/iscsid provided expected statsn
@ 2010-03-25 17:54 Anil Veerabhadrappa
2010-03-25 19:25 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Anil Veerabhadrappa @ 2010-03-25 17:54 UTC (permalink / raw)
To: James.Bottomley, michaelc; +Cc: linux-scsi, open-iscsi, mchan, waie
[BNX2I] instruct firmware to use driver/iscsid provided expected statsn
field while constructing login pdu header.
* Initialize 'flags' to instruct chip to use driver/iscsid provided
ExpStatSN value while constructing iSCSI login PDU header
Signed-off-by: Eddie Wai <waie@broadcom.com>
Signed-off-by: Anil Veerabhadrappa <anilgv@broadcom.com>
---
drivers/scsi/bnx2i/bnx2i_hwi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_hwi.c b/drivers/scsi/bnx2i/bnx2i_hwi.c
index 1af578d..d5d8234 100644
--- a/drivers/scsi/bnx2i/bnx2i_hwi.c
+++ b/drivers/scsi/bnx2i/bnx2i_hwi.c
@@ -346,6 +346,7 @@ int bnx2i_send_iscsi_login(struct bnx2i_conn *bnx2i_conn,
login_wqe->cmd_sn = be32_to_cpu(login_hdr->cmdsn);
login_wqe->exp_stat_sn = be32_to_cpu(login_hdr->exp_statsn);
+ login_wqe->flags = ISCSI_LOGIN_REQUEST_UPDATE_EXP_STAT_SN;
login_wqe->resp_bd_list_addr_lo = (u32) bnx2i_conn->gen_pdu.resp_bd_dma;
login_wqe->resp_bd_list_addr_hi =
@@ -355,7 +356,6 @@ int bnx2i_send_iscsi_login(struct bnx2i_conn *bnx2i_conn,
(bnx2i_conn->gen_pdu.resp_buf_size <<
ISCSI_LOGIN_REQUEST_RESP_BUFFER_LENGTH_SHIFT));
login_wqe->resp_buffer = dword;
- login_wqe->flags = 0;
login_wqe->bd_list_addr_lo = (u32) bnx2i_conn->gen_pdu.req_bd_dma;
login_wqe->bd_list_addr_hi =
(u32) ((u64) bnx2i_conn->gen_pdu.req_bd_dma >> 32);
--
1.6.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] [BNX2I] instruct firmware to use driver/iscsid provided expected statsn
2010-03-25 17:54 [PATCH 1/3] [BNX2I] instruct firmware to use driver/iscsid provided expected statsn Anil Veerabhadrappa
@ 2010-03-25 19:25 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2010-03-25 19:25 UTC (permalink / raw)
To: Anil Veerabhadrappa; +Cc: James.Bottomley, linux-scsi, open-iscsi, mchan, waie
On 03/25/2010 12:54 PM, Anil Veerabhadrappa wrote:
> [BNX2I] instruct firmware to use driver/iscsid provided expected statsn
> field while constructing login pdu header.
>
> * Initialize 'flags' to instruct chip to use driver/iscsid provided
> ExpStatSN value while constructing iSCSI login PDU header
>
> Signed-off-by: Eddie Wai<waie@broadcom.com>
> Signed-off-by: Anil Veerabhadrappa<anilgv@broadcom.com>
>
All three patches look ok.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-25 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 17:54 [PATCH 1/3] [BNX2I] instruct firmware to use driver/iscsid provided expected statsn Anil Veerabhadrappa
2010-03-25 19:25 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).