public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockrwd@gmail.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Andy Yan <ayan@marvell.com>, Ke Wei <kewei@marvell.com>,
	Ying Chu <jasonchu@marvell.com>,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue
Date: Tue, 20 Apr 2010 18:17:01 -0600	[thread overview]
Message-ID: <4BCE43FD.1080303@gmail.com> (raw)
In-Reply-To: <20100420141616.GP4586@mail.wantstofly.org>

On 04/20/2010 08:16 AM, Lennert Buytenhek wrote:
> On mvsas, when I issue a SMART command (smartctl -a) while a dd
> from /dev/sda to /dev/null is in progress, I hit the following
> WARN_ON_ONCE in ata_qc_issue():
>
>          if (ata_is_ncq(prot)) {
>                  WARN_ON_ONCE(link->sactive&  (1<<  qc->tag));
>
>                  if (!link->sactive)
>                          ap->nr_active_links++;
>                  link->sactive |= 1<<  qc->tag;
>          } else {
>                  WARN_ON_ONCE(link->sactive);		<===============
>
>                  ap->nr_active_links++;
>                  link->active_tag = qc->tag;
>          }
>
> This is on 2.6.34-rc4 ish.

That would indicate that for some reason, non-NCQ commands aren't being 
deferred while an NCQ command is in progress. Presumably something wrong 
in mvsas or libsas code in general..

  reply	other threads:[~2010-04-21  0:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-20 14:16 WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue Lennert Buytenhek
2010-04-21  0:17 ` Robert Hancock [this message]
2010-04-21  1:55   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BCE43FD.1080303@gmail.com \
    --to=hancockrwd@gmail.com \
    --cc=ayan@marvell.com \
    --cc=buytenh@wantstofly.org \
    --cc=jasonchu@marvell.com \
    --cc=kewei@marvell.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox