* WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue
@ 2010-04-20 14:16 Lennert Buytenhek
2010-04-21 0:17 ` Robert Hancock
0 siblings, 1 reply; 3+ messages in thread
From: Lennert Buytenhek @ 2010-04-20 14:16 UTC (permalink / raw)
To: Andy Yan, Ke Wei, Ying Chu; +Cc: linux-ide, linux-scsi
On mvsas, when I issue a SMART command (smartctl -a) while a dd
from /dev/sda to /dev/null is in progress, I hit the following
WARN_ON_ONCE in ata_qc_issue():
if (ata_is_ncq(prot)) {
WARN_ON_ONCE(link->sactive & (1 << qc->tag));
if (!link->sactive)
ap->nr_active_links++;
link->sactive |= 1 << qc->tag;
} else {
WARN_ON_ONCE(link->sactive); <===============
ap->nr_active_links++;
link->active_tag = qc->tag;
}
This is on 2.6.34-rc4 ish.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue
2010-04-20 14:16 WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue Lennert Buytenhek
@ 2010-04-21 0:17 ` Robert Hancock
2010-04-21 1:55 ` Jeff Garzik
0 siblings, 1 reply; 3+ messages in thread
From: Robert Hancock @ 2010-04-21 0:17 UTC (permalink / raw)
To: Lennert Buytenhek; +Cc: Andy Yan, Ke Wei, Ying Chu, linux-ide, linux-scsi
On 04/20/2010 08:16 AM, Lennert Buytenhek wrote:
> On mvsas, when I issue a SMART command (smartctl -a) while a dd
> from /dev/sda to /dev/null is in progress, I hit the following
> WARN_ON_ONCE in ata_qc_issue():
>
> if (ata_is_ncq(prot)) {
> WARN_ON_ONCE(link->sactive& (1<< qc->tag));
>
> if (!link->sactive)
> ap->nr_active_links++;
> link->sactive |= 1<< qc->tag;
> } else {
> WARN_ON_ONCE(link->sactive); <===============
>
> ap->nr_active_links++;
> link->active_tag = qc->tag;
> }
>
> This is on 2.6.34-rc4 ish.
That would indicate that for some reason, non-NCQ commands aren't being
deferred while an NCQ command is in progress. Presumably something wrong
in mvsas or libsas code in general..
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue
2010-04-21 0:17 ` Robert Hancock
@ 2010-04-21 1:55 ` Jeff Garzik
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2010-04-21 1:55 UTC (permalink / raw)
To: Robert Hancock
Cc: Lennert Buytenhek, Andy Yan, Ke Wei, Ying Chu, linux-ide,
linux-scsi
On 04/20/2010 08:17 PM, Robert Hancock wrote:
> On 04/20/2010 08:16 AM, Lennert Buytenhek wrote:
>> On mvsas, when I issue a SMART command (smartctl -a) while a dd
>> from /dev/sda to /dev/null is in progress, I hit the following
>> WARN_ON_ONCE in ata_qc_issue():
>>
>> if (ata_is_ncq(prot)) {
>> WARN_ON_ONCE(link->sactive& (1<< qc->tag));
>>
>> if (!link->sactive)
>> ap->nr_active_links++;
>> link->sactive |= 1<< qc->tag;
>> } else {
>> WARN_ON_ONCE(link->sactive); <===============
>>
>> ap->nr_active_links++;
>> link->active_tag = qc->tag;
>> }
>>
>> This is on 2.6.34-rc4 ish.
>
> That would indicate that for some reason, non-NCQ commands aren't being
> deferred while an NCQ command is in progress. Presumably something wrong
> in mvsas or libsas code in general..
Yep, definitely a problem in the mvsas (or libsas) area.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-04-21 1:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-20 14:16 WARN_ON() in drivers/ata/libata-core.c:5211 ata_qc_issue Lennert Buytenhek
2010-04-21 0:17 ` Robert Hancock
2010-04-21 1:55 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox