From: Tejun Heo <tj@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: linux-scsi@vger.kernel.org, linux-usb <linux-usb@vger.kernel.org>
Subject: Re: Using get_last_written() in sr.c causes problems with some usb devices (bz.kernel.org 9668)
Date: Tue, 27 Apr 2010 11:50:54 +0200 [thread overview]
Message-ID: <4BD6B37E.2060205@kernel.org> (raw)
In-Reply-To: <4BD6B1B3.30707@redhat.com>
Hello,
On 04/27/2010 11:43 AM, Hans de Goede wrote:
> The only thing I can come up with to fix this is a device specific
> quirk. Either in sr.c or in ubs-storage. Which is not a very
> pretty solution, hence this mail in the hope someone has
> a clever idea.
For cases like this, I think quirking is the cleanest solution.
Trying to modify generic behavior to accomodate special cases
sometimes create unexpected subtle issues in other devices and as the
fix itself is buried in the general seemingly unrelated logic, it's
relatively easy to lose the workaround later during an unrelated
update.
Is the device uniquely identifiable?
Thanks.
--
tejun
next prev parent reply other threads:[~2010-04-27 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 9:43 Using get_last_written() in sr.c causes problems with some usb devices (bz.kernel.org 9668) Hans de Goede
2010-04-27 9:50 ` Tejun Heo [this message]
[not found] ` <4BD6B37E.2060205-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2010-04-27 10:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD6B37E.2060205@kernel.org \
--to=tj@kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).