From: Randy Dunlap <randy.dunlap@oracle.com>
To: James Bottomley <James.Bottomley@suse.de>
Cc: scsi <linux-scsi@vger.kernel.org>, Karen Xie <kxie@chelsio.com>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] scsi: fix cxgb3i build errors
Date: Tue, 04 May 2010 14:52:25 -0700 [thread overview]
Message-ID: <4BE09719.8060907@oracle.com> (raw)
In-Reply-To: <1272994590.5255.32.camel@mulgrave.site>
On 05/04/10 10:36, James Bottomley wrote:
> On Tue, 2010-05-04 at 10:28 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> cxgb3i should depend on NET since it selects SCSI_ISCSI_ATTRS,
>> which depends on NET.
>> This change fixes multiple build (link) errors:
>>
>> ERROR: "skb_trim" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "netlink_kernel_create" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "netlink_kernel_release" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "skb_pull" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "init_net" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "__alloc_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "netlink_broadcast" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "kfree_skb" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>> ERROR: "skb_put" [drivers/scsi/scsi_transport_iscsi.ko] undefined!
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: Karen Xie <kxie@chelsio.com>
>> ---
>> drivers/scsi/cxgb3i/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-2634-rc6.orig/drivers/scsi/cxgb3i/Kconfig
>> +++ lnx-2634-rc6/drivers/scsi/cxgb3i/Kconfig
>> @@ -1,6 +1,6 @@
>> config SCSI_CXGB3_ISCSI
>> tristate "Chelsio S3xx iSCSI support"
>> - depends on CHELSIO_T3_DEPENDS
>> + depends on CHELSIO_T3_DEPENDS && NET
>
> Something's seriously wrong here.
>
> CHELSIO_T3_DEPENDS is supposed to be the rollup for all the
> dependencies. It's actually defined as this:
>
> config CHELSIO_T3_DEPENDS
> tristate
> depends on PCI && INET
> default y
>
> INET is the tcp/ip stack ... so how did you build a kernel that has
> NET=n and INET=y (it's guarded by an #if NET in the Kconfig file)?
Hm, I managed to do that somehow, but I didn't save the Kconfig file
and I can't make it happen again, so just drop this patch. Thanks.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
prev parent reply other threads:[~2010-05-04 21:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 17:28 [PATCH] scsi: fix cxgb3i build errors Randy Dunlap
2010-05-04 17:36 ` James Bottomley
2010-05-04 21:52 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE09719.8060907@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).