From: Mike Christie <michaelc@cs.wisc.edu>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: james.bottomley@suse.de, linux-scsi@vger.kernel.org,
ravi.anand@qlogic.com
Subject: Re: [PATCH 1/7] qla4xxx: added BSG support
Date: Tue, 11 May 2010 10:51:10 -0500 [thread overview]
Message-ID: <4BE97CEE.8060404@cs.wisc.edu> (raw)
In-Reply-To: <20100511075526.GA30474@sles11sp1b1.qlogic.org>
I think we need James's comments on this one. I am not sure what is right.
On 05/11/2010 02:55 AM, Vikas Chaudhary wrote:
> This BSG interface is on top of patch :
> http://marc.info/?l=linux-scsi&m=126884917217355&w=2
>
All I want to be able to do is allow any app to be able to config any
iscsi cards. I want to support Qlogic apps, but then I also want to
support iscsiadm, virt tools, installers, boot tools, etc.
> + case ISCSI_BSG_HST_VENDOR:
> + rval = qla4xxx_process_vendor_specific(job);
> + break;
I like the idea of allowing you to use the ISCSI_BSG_HST_VENDOR for all
your commands, because it makes the kernel code so very very simple. If
you guys can provide a userspace gpl friendly lib or plugin to a lib
like IMA that allows distros tools to manage your card, then I am happy
with this approach.
My concern with this is that, it takes you guys so long to get things
out. We have no idea when or if it will ever be done.
> + case ISCSI_BSG_HST_NET_CONFIG:
> + printk(KERN_ERR "ISCSI_BSG_HST_NET_CONFIG Commands "
> + "NOT Supported\n");
> + rval = -ENOSYS;
> + break;
OTOH, I like the idea of ethtool like interface where for common
operations there is a command command. Then the driver takes that
info/cmd and does its vendor specifics.
James, someone mentioned that in the past you might have said it is ok
to pass blobs around if it gets passed down directly to hardware. This
is the case for qla4xxx here. Is it ok to let them just use the
HST_VENDOR command?
next prev parent reply other threads:[~2010-05-11 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 7:55 [PATCH 1/7] qla4xxx: added BSG support Vikas Chaudhary
2010-05-11 15:51 ` Mike Christie [this message]
[not found] ` <39177E34-293B-47ED-864A-1304477375EC@qlogic.com>
2010-05-25 4:08 ` Vikas Chaudhary
2010-06-01 18:31 ` Ravi Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE97CEE.8060404@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=james.bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).