From: Mike Christie <michaelc@cs.wisc.edu>
To: Dan Carpenter <error27@gmail.com>
Cc: Jayamohan Kallickal <jayamohank@serverengines.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] be2iscsi: null dereference on error path
Date: Thu, 10 Jun 2010 15:43:17 -0500 [thread overview]
Message-ID: <4C114E65.90305@cs.wisc.edu> (raw)
In-Reply-To: <20100610075305.GJ5483@bicker>
On 06/10/2010 02:53 AM, Dan Carpenter wrote:
> "phba" is always null here so we can't dereference it.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 779e1d1..efadde9 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
>
> ret = beiscsi_enable_pci(pcidev);
> if (ret< 0) {
> - shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
> - "Failed to enable pci device \n");
> + dev_err(&pcidev->dev, "beiscsi_dev_probe-"
> + " Failed to enable pci device\n");
> return ret;
> }
>
Looks good. Thanks.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2010-06-10 20:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 7:53 [patch 2/2] be2iscsi: null dereference on error path Dan Carpenter
2010-06-10 20:43 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C114E65.90305@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=error27@gmail.com \
--cc=jayamohank@serverengines.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox