* [patch 2/2] be2iscsi: null dereference on error path
@ 2010-06-10 7:53 Dan Carpenter
2010-06-10 20:43 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-06-10 7:53 UTC (permalink / raw)
To: Jayamohan Kallickal
Cc: James E.J. Bottomley, Mike Christie, linux-scsi, kernel-janitors
"phba" is always null here so we can't dereference it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 779e1d1..efadde9 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
ret = beiscsi_enable_pci(pcidev);
if (ret < 0) {
- shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
- "Failed to enable pci device \n");
+ dev_err(&pcidev->dev, "beiscsi_dev_probe-"
+ " Failed to enable pci device\n");
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2] be2iscsi: null dereference on error path
2010-06-10 7:53 [patch 2/2] be2iscsi: null dereference on error path Dan Carpenter
@ 2010-06-10 20:43 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2010-06-10 20:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jayamohan Kallickal, James E.J. Bottomley, linux-scsi,
kernel-janitors
On 06/10/2010 02:53 AM, Dan Carpenter wrote:
> "phba" is always null here so we can't dereference it.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 779e1d1..efadde9 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -3774,8 +3774,8 @@ static int __devinit beiscsi_dev_probe(struct pci_dev *pcidev,
>
> ret = beiscsi_enable_pci(pcidev);
> if (ret< 0) {
> - shost_printk(KERN_ERR, phba->shost, "beiscsi_dev_probe-"
> - "Failed to enable pci device \n");
> + dev_err(&pcidev->dev, "beiscsi_dev_probe-"
> + " Failed to enable pci device\n");
> return ret;
> }
>
Looks good. Thanks.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-10 20:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-10 7:53 [patch 2/2] be2iscsi: null dereference on error path Dan Carpenter
2010-06-10 20:43 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox