From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: [patch 1/2] be2iscsi: memory leak on error path Date: Thu, 10 Jun 2010 15:44:05 -0500 Message-ID: <4C114E95.7080401@cs.wisc.edu> References: <20100610075221.GI5483@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:58952 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759261Ab0FJUl6 (ORCPT ); Thu, 10 Jun 2010 16:41:58 -0400 In-Reply-To: <20100610075221.GI5483@bicker> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Dan Carpenter Cc: Jayamohan Kallickal , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org On 06/10/2010 02:52 AM, Dan Carpenter wrote: > I added a kfree(pwrb_arr) in front of the return. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c > index dd5b105..779e1d1 100644 > --- a/drivers/scsi/be2iscsi/be_main.c > +++ b/drivers/scsi/be2iscsi/be_main.c > @@ -2750,6 +2750,7 @@ beiscsi_create_wrb_rings(struct beiscsi_hba *phba, > if (status != 0) { > shost_printk(KERN_ERR, phba->shost, > "wrbq create failed."); > + kfree(pwrb_arr); > return status; > } > phwi_ctrlr->wrb_context[i * 2].cid = phwi_context->be_wrbq[i]. Looks good. Thanks. Reviewed-by: Mike Christie