From: Mike Christie <michaelc@cs.wisc.edu>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: james.bottomley@suse.de, linux-scsi@vger.kernel.org,
ravi.anand@qlogic.com
Subject: Re: [PATCH 11/15] iscsi_transport: Added new iscsi_host_param for iSCSI transport
Date: Sun, 13 Jun 2010 14:40:08 -0500 [thread overview]
Message-ID: <4C153418.5000705@cs.wisc.edu> (raw)
In-Reply-To: <20100611074819.GA27808@sles11sp1b1.qlogic.org>
On 06/11/2010 02:48 AM, Vikas Chaudhary wrote:
> + case ISCSI_HOST_PARAM_IF_TYPE:
> + len = sprintf(buf, "%s\n", ((ha->addl_fw_state&
> + FW_ADDSTATE_OPTICAL_MEDIA) != 0) ?
> + "Optical" : "Copper");
I think it is best to add a table that maps some enum ISCSI_IF_TYPE to a
string in scsi_transport_iscsi.c, then have the driver set the type on
the iscsi_cls_host struct. scsi_tranpoort_iscsi.c would then just do the
work of concerting and printing. This way we can make sure all the
drivers print out their values in the same format. It would be like
scsi_transport_fc.c's fc_port_speed_names or cos.
prev parent reply other threads:[~2010-06-13 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 7:48 [PATCH 11/15] iscsi_transport: Added new iscsi_host_param for iSCSI transport Vikas Chaudhary
2010-06-13 19:40 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C153418.5000705@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=james.bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox