public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* megaraid_sas locks down frame count to 8
@ 2010-06-14 14:30 Hannes Reinecke
  0 siblings, 0 replies; only message in thread
From: Hannes Reinecke @ 2010-06-14 14:30 UTC (permalink / raw)
  To: Yang, Bo; +Cc: SCSI Mailing List

Hi all,

we have this bit in drivers/scsi/megaraid/megaraid_sas.c:799

	if (frame_count > 7)
		frame_count = 8;

which is supposed to report the number of frames required
to handle the passed in sg list.
This results in a nice memory scribble if we pass in a
large enough sg list, as the sg list contents will then
written in the memory area for the next frame.

Any comments here?

If it were me I would just remove that check, but
then LSI might have a valid reason for doing so.

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-14 14:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-14 14:30 megaraid_sas locks down frame count to 8 Hannes Reinecke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox