From: Mike Christie <michaelc@cs.wisc.edu>
To: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Cc: james.bottomley@suse.de, linux-scsi@vger.kernel.org,
ravi.anand@qlogic.com, karen.higgins@qlogic.com
Subject: Re: [PATCH 07/11] qla4xxx: Added support for ISP82XX
Date: Wed, 16 Jun 2010 17:02:41 -0500 [thread overview]
Message-ID: <4C194A01.1080809@cs.wisc.edu> (raw)
In-Reply-To: <20100616205403.GA8178@sles11sp1b1.qlogic.org>
On 06/16/2010 03:54 PM, Vikas Chaudhary wrote:
> } else {
> DEBUG2(printk("scsi%ld: Unknown mailbox status %08X\n",
> ha->host_no, mbox_status));
>
> - ha->mbox_status[0] = mbox_status;
> + ha->mbox_status[0] = mbox_sts[0];
> }
> }
Is this right? mbox_sts[0] is not set at this point, and you get:
drivers/scsi/qla4xxx/ql4_isr.c: In function ‘qla4xxx_isr_decode_mailbox’:
drivers/scsi/qla4xxx/ql4_isr.c:634: warning: ‘mbox_sts’ may be used
uninitialized in this function
We should not hit the case though, right. Maybe in a follow up patch you
can fix this since the rest of the patches look ok, and I do not want to
look a them ever again :)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-16 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 20:54 [PATCH 07/11] qla4xxx: Added support for ISP82XX Vikas Chaudhary
2010-06-16 22:02 ` Mike Christie [this message]
2010-06-16 22:57 ` Vikas Chaudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C194A01.1080809@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=james.bottomley@suse.de \
--cc=karen.higgins@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox