From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used Date: Fri, 18 Jun 2010 13:38:19 -0700 Message-ID: <4C1BD93B.1080600@gmail.com> References: <1276892167-24161-1-git-send-email-justinmattock@gmail.com> <1276892898.2850.389.camel@mulgrave.site> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:52108 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919Ab0FRUiU (ORCPT ); Fri, 18 Jun 2010 16:38:20 -0400 Received: by pwi1 with SMTP id 1so594647pwi.19 for ; Fri, 18 Jun 2010 13:38:20 -0700 (PDT) In-Reply-To: <1276892898.2850.389.camel@mulgrave.site> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James Bottomley Cc: linux-scsi@vger.kernel.org On 06/18/2010 01:28 PM, James Bottomley wrote: > On Fri, 2010-06-18 at 13:16 -0700, Justin P. Mattock wrote: >> The below patch fixes a warning message generated by gcc 4.6.0 >> CC drivers/scsi/hosts.o >> drivers/scsi/hosts.c: In function 'scsi_host_alloc': >> drivers/scsi/hosts.c:328:6: warning: variable 'rval' set but not used > > OK, patch looks fine now, thanks! But this isn't: > >> Signed-off-by: James Bottomley > > You need to read Documentation/SubmittingPatches for the full story, but > you can't just add signed-off-by; you need an explicit email from the > person saying that ... plus, signoffs should follow the natural > progression of the patch, so if it's your patch, and you send it to me, > I'll add my signoff before I put it in the tree. This has a legal basis > in the DCO (see SubmittinPatches). We're a lot looser on the various > other tags, though. > > Anyway, the above is more for future reference; I'll fix it up. > > James alright!! and Thanks for be patient with me... > >> Signed-off-by: Justin P. Mattock >> >> --- >> drivers/scsi/hosts.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c >> index 6660fa9..4cc99b7 100644 >> --- a/drivers/scsi/hosts.c >> +++ b/drivers/scsi/hosts.c >> @@ -325,7 +325,6 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) >> { >> struct Scsi_Host *shost; >> gfp_t gfp_mask = GFP_KERNEL; >> - int rval; >> >> if (sht->unchecked_isa_dma&& privsize) >> gfp_mask |= __GFP_DMA; >> @@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize) >> shost->ehandler = kthread_run(scsi_error_handler, shost, >> "scsi_eh_%d", shost->host_no); >> if (IS_ERR(shost->ehandler)) { >> - rval = PTR_ERR(shost->ehandler); >> + printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n", >> + shost->host_no, PTR_ERR(shost->ehandler)); >> goto fail_kfree; >> } >> > > >