From: "Justin P. Mattock" <justinmattock@gmail.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used
Date: Fri, 18 Jun 2010 14:24:54 -0700 [thread overview]
Message-ID: <4C1BE426.30606@gmail.com> (raw)
In-Reply-To: <20100618204730.GL9298@parisc-linux.org>
On 06/18/2010 01:47 PM, Matthew Wilcox wrote:
> On Fri, Jun 18, 2010 at 01:16:07PM -0700, Justin P. Mattock wrote:
>> @@ -420,7 +419,8 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
>> shost->ehandler = kthread_run(scsi_error_handler, shost,
>> "scsi_eh_%d", shost->host_no);
>> if (IS_ERR(shost->ehandler)) {
>> - rval = PTR_ERR(shost->ehandler);
>> + printk(KERN_WARNING "scsi%d: error handler thread failed to spawn, error = %ld\n",
>> + shost->host_no, PTR_ERR(shost->ehandler));
>
> Surely this should simply be:
>
> shost_printk(KERN_WARNING, shost, "error handler thread failed"
> "to spawn (%ld)\n", PTR_ERR(shost->ehandler));
>
>> goto fail_kfree;
>> }
>>
>> --
>> 1.7.1.rc1.21.gf3bd6
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
the above change goes through without a warning message.. should I resend?
Justin P. Mattock
next prev parent reply other threads:[~2010-06-18 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-18 20:16 [PATCH 5/5 v2]scsi:hosts.c Fix warning: variable 'rval' set but not used Justin P. Mattock
2010-06-18 20:28 ` James Bottomley
2010-06-18 20:38 ` Justin P. Mattock
2010-06-18 20:47 ` Matthew Wilcox
2010-06-18 21:24 ` Justin P. Mattock [this message]
2010-06-19 19:32 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1BE426.30606@gmail.com \
--to=justinmattock@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox