From: Jens Axboe <jaxboe@fusionio.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Mike Snitzer <snitzer@redhat.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
"James.Bottomley@suse.de" <James.Bottomley@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>
Subject: Re: [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path
Date: Wed, 07 Jul 2010 21:46:00 +0200 [thread overview]
Message-ID: <4C34D978.8060904@fusionio.com> (raw)
In-Reply-To: <20100707194431.GA20206@lst.de>
On 07/07/10 21.44, Christoph Hellwig wrote:
>> Here is a minimalist patch that 1) removes the discard request's page
>> leak 2) preserves the prep cleanup rules covered above. Fixing the leak
>> is a priority, introducing additional error path code sharing/cleanup is
>> secondary and can come later.
>
> I much prefer this approach.
Same here, it's the correct layering. I'll queue this up, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2010-07-07 19:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-05 4:00 [PATCH] scsi: unify the error handling of the prep functions FUJITA Tomonori
2010-07-05 13:45 ` Mike Snitzer
2010-07-06 13:59 ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path (was: Re: scsi: unify the error handling of the prep functions) Mike Snitzer
2010-07-07 19:44 ` Christoph Hellwig
2010-07-07 19:46 ` Jens Axboe [this message]
2010-07-08 4:17 ` FUJITA Tomonori
2010-07-08 12:06 ` Mike Snitzer
2010-07-08 12:10 ` [PATCH v2] scsi: address leak in scsi_setup_discard_cmnd error path Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C34D978.8060904@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=James.Bottomley@suse.de \
--cc=dm-devel@redhat.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).