From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 09/19] be2iscsi: Adding crashdump support
Date: Thu, 22 Jul 2010 17:26:21 -0500 [thread overview]
Message-ID: <4C48C58D.5000805@cs.wisc.edu> (raw)
In-Reply-To: <20100721225442.GA9517@serverengines.com>
On 07/21/2010 05:54 PM, Jayamohan Kallickal wrote:
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index 67a7e3f..1a22125 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -41,6 +41,8 @@
> static unsigned int be_iopoll_budget = 10;
> static unsigned int be_max_phys_size = 64;
> static unsigned int enable_msix = 1;
> +static unsigned int gcrashmode = 0;
> +static unsigned int num_hba = 0;
>
You do not need to init to 0 when they are static (checkpatch.pl can
find this stuff for you).
I think it is ok to fix this on a later patch so the rest can go in.
prev parent reply other threads:[~2010-07-22 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 22:54 [PATCH 09/19] be2iscsi: Adding crashdump support Jayamohan Kallickal
2010-07-22 22:26 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C48C58D.5000805@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).