From: Mike Christie <michaelc@cs.wisc.edu>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-scsi@vger.kernel.org, dm-devel@redhat.com
Subject: Re: rq-based mpath failed path on SCSI target failure (malformed discard)
Date: Mon, 26 Jul 2010 11:23:25 -0500 [thread overview]
Message-ID: <4C4DB67D.1070903@cs.wisc.edu> (raw)
In-Reply-To: <20100726150000.GA31293@redhat.com>
On 07/26/2010 10:00 AM, Mike Snitzer wrote:
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index ec2b43e..125c80f 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1272,6 +1272,9 @@ static int do_end_io(struct multipath *m, struct request *clone,
> if (error == -EOPNOTSUPP)
> return error;
>
> + if (clone->cmd_flags& REQ_DISCARD)
> + return error; /* pass all discard request failures up */
> +
If a discard where failed due to a transport problem then you are going
to fail the IO instead of just retrying on another path.
You need something like Hannes's work to pass up the sense, or something
like generic block error codes like I started to work on, so you know
why the IO failed.
next prev parent reply other threads:[~2010-07-26 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 13:30 rq-based mpath failed path on SCSI target failure (malformed discard) Mike Snitzer
2010-07-26 15:00 ` Mike Snitzer
2010-07-26 16:23 ` Mike Christie [this message]
2010-07-26 17:40 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4DB67D.1070903@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=dm-devel@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).