From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 0/6] Remove owner field from sysfs attribute structure Date: Fri, 30 Jul 2010 10:45:48 +0200 Message-ID: <4C52913C.9020204@kernel.org> References: <1280380166-29196-1-git-send-email-guenter.roeck@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1280380166-29196-1-git-send-email-guenter.roeck@ericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org To: Guenter Roeck Cc: Mark Brown , Jani Nikula , Linus Walleij , James Smart , "Eric W. Biederman" , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Chris Wright , linuxppc-dev@ozlabs.org, "James E.J. Bottomley" , Richard Purdie , Nick Cheng , Dmitry Torokhov , Jean Delvare , Paul Mackerras , Benjamin Thery , linux-scsi@vger.kernel.org, Alex Iannicelli , Liam Girdwood List-Id: linux-scsi@vger.kernel.org On 07/29/2010 07:09 AM, Guenter Roeck wrote: > The following comment is found in include/linux/sysfs.h: > > /* FIXME > * The *owner field is no longer used. > * x86 tree has been cleaned up. The owner > * attribute is still left for other arches. > */ > > As it turns out, the *owner field is (again?) initialized in several modules, > suggesting that such initialization may be creeping back into the code. > > This patch set removes the above comment, the *owner field, and each instance > in the code where it was found to be initialized. > > Compiled with x86 allmodconfig as well as with all alpha, arm, mips, powerpc, > and sparc defconfig builds. Yeah, the change is way overdue. Maybe we should have just removed them back then. Acked-by: Tejun Heo Thanks. -- tejun