From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Christie Subject: Re: dev_loss_tmo behavior question Date: Fri, 30 Jul 2010 12:21:49 -0500 Message-ID: <4C530A2D.5070507@cs.wisc.edu> References: <4C4F4B94.1070009@cs.wisc.edu> <4C5055AA.7080703@emulex.com> <20100728165707.GA9844@plapp.qlogic.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from sabe.cs.wisc.edu ([128.105.6.20]:33158 "EHLO sabe.cs.wisc.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758686Ab0G3Rod (ORCPT ); Fri, 30 Jul 2010 13:44:33 -0400 In-Reply-To: <20100728165707.GA9844@plapp.qlogic.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Andrew Vasquez Cc: James Smart , "brking@linux.vnet.ibm.com" , SCSI Mailing List , "Desai, Kashyap" , Giridhar Malavali , Christof Schmitt , "Love, Robert W" , Jing Huang On 07/28/2010 11:57 AM, Andrew Vasquez wrote: > I'm curious though, each driver would still need to seed the rport's > dev_loss_tmo value (in the case of qla2xxx, > ha->port_down_retry_count), but, by doing so after rport-addition > (fc_remote_port_add()), the driver could still overwrite a previous > sysfs setting. Internally, upon rport creation, the dev_loss_tmo > value is seeding with fc_dev_loss_tmo (a module parameter -- 60 > seconds). Should we extend the transport so the the 'default seeding > value' can be specified once at fc_host creation-time? > I was going to add a fc_transport callout that gets called when the rport is allocated so drivers can do other rport initialization if they wanted. It is only called the first time when it is actually allocated not every time fc_remote_port_add is called. Would that be more useful?