From: Konstantinos Skarlatos <k.skarlatos@gmail.com>
To: David Milburn <dmilburn@redhat.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de,
sgruszka@redhat.com, satyasrinivasp@hcl.in, jeff@garzik.org
Subject: Re: [PATCH] mvsas: mvs_lu_reset iterates phy num times when releasing task
Date: Fri, 06 Aug 2010 20:21:16 +0300 [thread overview]
Message-ID: <4C5C448C.2040509@gmail.com> (raw)
In-Reply-To: <20100806161622.GA8696@localhost.localdomain>
Hello,
Does this patch fix any of the mvs_abort_task:rc= 5 and the other
problems that are being reported for this driver? for more info please
see http://marc.info/?l=linux-scsi&m=127583131805429&w=2
On 6/8/2010 7:16 μμ, David Milburn wrote:
> mvs_lu_reset should not call mvs_release_task phy number of times,
> each phy is handled in mvs_release_task.
>
> Signed-off-by: David Milburn<dmilburn@redhat.com>
> Cc: Stanislaw Gruszka<sgruszka@redhat.com>
> Cc: Srinivas<satyasrinivasp@hcl.in>
> Cc: Andy Yan<ayan@marvell.com>
> ---
> drivers/scsi/mvsas/mv_sas.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index adedaa9..013ab8d 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -1551,7 +1551,7 @@ static int mvs_debug_I_T_nexus_reset(struct domain_device *dev)
> int mvs_lu_reset(struct domain_device *dev, u8 *lun)
> {
> unsigned long flags;
> - int i, phyno[WIDE_PORT_MAX_PHY], num , rc = TMF_RESP_FUNC_FAILED;
> + int rc = TMF_RESP_FUNC_FAILED;
> struct mvs_tmf_task tmf_task;
> struct mvs_device * mvi_dev = dev->lldd_dev;
> struct mvs_info *mvi = mvi_dev->mvi_info;
> @@ -1560,10 +1560,8 @@ int mvs_lu_reset(struct domain_device *dev, u8 *lun)
> mvi_dev->dev_status = MVS_DEV_EH;
> rc = mvs_debug_issue_ssp_tmf(dev, lun,&tmf_task);
> if (rc == TMF_RESP_FUNC_COMPLETE) {
> - num = mvs_find_dev_phyno(dev, phyno);
> spin_lock_irqsave(&mvi->lock, flags);
> - for (i = 0; i< num; i++)
> - mvs_release_task(mvi, dev);
> + mvs_release_task(mvi, dev);
> spin_unlock_irqrestore(&mvi->lock, flags);
> }
> /* If failed, fall-through I_T_Nexus reset */
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-08-06 17:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 16:16 [PATCH] mvsas: mvs_lu_reset iterates phy num times when releasing task David Milburn
2010-08-06 17:21 ` Konstantinos Skarlatos [this message]
2010-08-06 19:01 ` David Milburn
2010-08-09 8:17 ` Konstantinos Skarlatos
2010-09-03 22:13 ` David Milburn
2010-09-04 19:04 ` Konstantinos Skarlatos
2010-09-08 10:53 ` Konstantinos Skarlatos
2010-09-09 10:49 ` Konstantinos Skarlatos
2010-09-09 14:13 ` David Milburn
2010-09-11 15:57 ` Konstantinos Skarlatos
2010-09-15 13:49 ` David Milburn
2010-09-20 21:38 ` Konstantinos Skarlatos
2010-09-11 15:05 ` Konstantinos Skarlatos
2010-08-07 8:26 ` Jeff Garzik
2010-08-10 19:10 ` Audio Haven
2010-08-10 21:22 ` David Milburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5C448C.2040509@gmail.com \
--to=k.skarlatos@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=dmilburn@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=satyasrinivasp@hcl.in \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).