From: Peter Jones <pjones@redhat.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH -next] firmware: ibft depends on SCSI
Date: Thu, 12 Aug 2010 10:31:38 -0400 [thread overview]
Message-ID: <4C6405CA.3080701@redhat.com> (raw)
In-Reply-To: <20100811103620.2d25d573.randy.dunlap@oracle.com>
On 08/11/2010 01:36 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Prevent build errors when SCSI is not enabled:
>
> iscsi_ibft.c:(.init.text+0x548d): undefined reference to `iscsi_boot_create_initiator'
> iscsi_ibft.c:(.init.text+0x54a9): undefined reference to `iscsi_boot_create_ethernet'
> iscsi_ibft.c:(.init.text+0x54c5): undefined reference to `iscsi_boot_create_target'
> iscsi_ibft.c:(.init.text+0x55ff): undefined reference to `iscsi_boot_destroy_kset'
> iscsi_ibft.c:(.init.text+0x561e): undefined reference to `iscsi_boot_create_kset'
> iscsi_ibft.c:(.exit.text+0xe2c): undefined reference to `iscsi_boot_destroy_kset'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Peter Jones <pjones@redhat.com>
> Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>
This looks good to me, thanks for catching it.
Signed-of-by: Peter Jones <pjones@redhat.com>
> ---
> drivers/firmware/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20100811.orig/drivers/firmware/Kconfig
> +++ linux-next-20100811/drivers/firmware/Kconfig
> @@ -125,7 +125,7 @@ config ISCSI_IBFT_FIND
> config ISCSI_IBFT
> tristate "iSCSI Boot Firmware Table Attributes module"
> select ISCSI_BOOT_SYSFS
> - depends on ISCSI_IBFT_FIND
> + depends on ISCSI_IBFT_FIND && SCSI
> default n
> help
> This option enables support for detection and exposing of iSCSI
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Peter
RFC 882 put the dots in .com.
01234567890123456789012345678901234567890123456789012345678901234567890123456789
prev parent reply other threads:[~2010-08-12 14:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100811140009.6ff33109.sfr@canb.auug.org.au>
2010-08-11 17:36 ` [PATCH -next] firmware: ibft depends on SCSI Randy Dunlap
2010-08-12 14:31 ` Peter Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6405CA.3080701@redhat.com \
--to=pjones@redhat.com \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).