From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: [PATCH 1/1] be2iscsi: Fix for Login failure
Date: Thu, 12 Aug 2010 13:24:38 -0500 [thread overview]
Message-ID: <4C643C66.8030507@cs.wisc.edu> (raw)
In-Reply-To: <20100812180547.GA8202@serverengines.com>
On 08/12/2010 01:06 PM, Jayamohan Kallickal wrote:
> The current code in tree has problems with Login.
> This patch fixes the Login Failure .
>
> This patch has been made on the latest scsi-misc tree pulled today
>
> Signed-off-by: Jayamohan Kallickal<jayamohank@serverengines.com>
> ---
> drivers/scsi/be2iscsi/be_iscsi.c | 5 ++---
> drivers/scsi/be2iscsi/be_mgmt.c | 2 +-
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
> index 7d4d227..7f11f3e 100644
> --- a/drivers/scsi/be2iscsi/be_iscsi.c
> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> @@ -300,8 +300,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
> enum iscsi_host_param param, char *buf)
> {
> struct beiscsi_hba *phba = (struct beiscsi_hba *)iscsi_host_priv(shost);
> - int len = 0;
> - int status;
> + int status = 0;
>
> SE_DEBUG(DBG_LVL_8, "In beiscsi_get_host_param, param= %d\n", param);
> switch (param) {
> @@ -315,7 +314,7 @@ int beiscsi_get_host_param(struct Scsi_Host *shost,
> default:
> return iscsi_host_get_param(shost, param, buf);
> }
> - return len;
> + return status;
Can't believe I missed that.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
prev parent reply other threads:[~2010-08-12 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 18:06 [PATCH 1/1] be2iscsi: Fix for Login failure Jayamohan Kallickal
2010-08-12 18:24 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C643C66.8030507@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@suse.de \
--cc=jayamohank@serverengines.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox