linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] cxgbi iscsi driver
@ 2010-08-13  2:57 kxie-ut6Up61K2wZBDgjK7y7TUQ
  0 siblings, 0 replies; 4+ messages in thread
From: kxie-ut6Up61K2wZBDgjK7y7TUQ @ 2010-08-13  2:57 UTC (permalink / raw)
  To: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	open-iscsi-/JYPxA39Uh5TLH3MbocFFw
  Cc: rranjan-ut6Up61K2wZBDgjK7y7TUQ, kxie-ut6Up61K2wZBDgjK7y7TUQ,
	James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk,
	michaelc-hcNo3dDEHLuVc3sceRu5cw

[PATCH v2 0/3] cxgbi iscsi driver

From: Karen Xie <kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>

This patchset includes:

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

The version 2 includes the following changes:
- Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i
  are built into the kernel.
- Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template().
  The iscsi_transport and scsi_host_template are initialized in the drivers
  instead of being filled in by the library at runtime..
- Only register with iscsi class transport once per driver type. 

Thanks.
Karen

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2 0/3] cxgbi iscsi driver
@ 2010-08-13 15:19 kxie
  2010-08-13 15:49 ` Joe Perches
  2010-08-13 16:32 ` Mike Christie
  0 siblings, 2 replies; 4+ messages in thread
From: kxie @ 2010-08-13 15:19 UTC (permalink / raw)
  To: netdev, linux-scsi, open-iscsi
  Cc: rranjan, kxie, James.Bottomley, michaelc, davem

[PATCH v2 0/3] cxgbi iscsi driver

From: Karen Xie <kxie@chelsio.com>

Re-submission, missed netdev list last time.

This patchset includes:

1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
2. added cxgb4i iscsi initiator v5.
3. changed cxgb3i to use libcxgbi.

The version 2 includes the following changes:
- Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i
  are built into the kernel.
- Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template().
  The iscsi_transport and scsi_host_template are initialized in the drivers
  instead of being filled in by the library at runtime..
- Only register with iscsi class transport once per driver type. 

Thanks.
Karen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/3] cxgbi iscsi driver
  2010-08-13 15:19 [PATCH v2 0/3] cxgbi iscsi driver kxie
@ 2010-08-13 15:49 ` Joe Perches
  2010-08-13 16:32 ` Mike Christie
  1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-08-13 15:49 UTC (permalink / raw)
  To: kxie
  Cc: netdev, linux-scsi, open-iscsi, rranjan, James.Bottomley,
	michaelc, davem

On Fri, 2010-08-13 at 08:19 -0700, kxie@chelsio.com wrote:
> [PATCH v2 0/3] cxgbi iscsi driver
> From: Karen Xie <kxie@chelsio.com>
> Re-submission, missed netdev list last time.

Hi Karen.

I presume this is not to be applied as you've
already received some feedback on it and that
you are sending it to netdev for any additional
comments.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2 0/3] cxgbi iscsi driver
  2010-08-13 15:19 [PATCH v2 0/3] cxgbi iscsi driver kxie
  2010-08-13 15:49 ` Joe Perches
@ 2010-08-13 16:32 ` Mike Christie
  1 sibling, 0 replies; 4+ messages in thread
From: Mike Christie @ 2010-08-13 16:32 UTC (permalink / raw)
  To: kxie; +Cc: netdev, linux-scsi, open-iscsi, rranjan, James.Bottomley, davem

On 08/13/2010 10:19 AM, kxie@chelsio.com wrote:
> [PATCH v2 0/3] cxgbi iscsi driver
>
> From: Karen Xie<kxie@chelsio.com>
>
> Re-submission, missed netdev list last time.
>
> This patchset includes:
>
> 1. added libcxgbi as the common library for both cxgb4i and cxgb3i driver
> 2. added cxgb4i iscsi initiator v5.
> 3. changed cxgb3i to use libcxgbi.
>
> The version 2 includes the following changes:
> - Made dbg_level static to avoid compiling errors when both cxgb3i and cxgb4i
>    are built into the kernel.
> - Deleted cxgbi_fill_iscsi_transport() and cxgbi_fill_scsi_host_template().
>    The iscsi_transport and scsi_host_template are initialized in the drivers
>    instead of being filled in by the library at runtime..
> - Only register with iscsi class transport once per driver type.
>

iSCSI and SCSI parts look ok now. The network code should be reviewed by 
the netdev people, because I am not qualified to review that. Thanks for 
your work Karen.

Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-13 16:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-13 15:19 [PATCH v2 0/3] cxgbi iscsi driver kxie
2010-08-13 15:49 ` Joe Perches
2010-08-13 16:32 ` Mike Christie
  -- strict thread matches above, loose matches on Subject: below --
2010-08-13  2:57 kxie-ut6Up61K2wZBDgjK7y7TUQ

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).