linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers
@ 2010-08-16 22:17 Vu Pham
  2010-08-16 23:51 ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Vu Pham @ 2010-08-16 22:17 UTC (permalink / raw)
  To: Roland Dreier; +Cc: Linux RDMA, OpenFabrics EWG, Linux SCSI

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: 0010-mlx4_fc-Enable-FC-over-Ethernet-Infiniband-drivers.patch --]
[-- Type: text/x-patch, Size: 2028 bytes --]

>From 17b0c5412e085e1f288c05cb667ec36e4a05c59b Mon Sep 17 00:00:00 2001
From: Vu Pham <vu-OnC3O1emZK9LiOotz6YBiwC/G2K4zDHf@public.gmane.org>
Date: Mon, 16 Aug 2010 14:48:01 -0700
Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Add entries in scsi's Kconfig and Makefile to enable mlx4_fc
(fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery
driver)

Signed-off-by: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/scsi/Kconfig  |   22 ++++++++++++++++++++++
 drivers/scsi/Makefile |    2 ++
 2 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 158284f..3573cee 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -687,6 +687,28 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	depends on MLX4_EN
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc
+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric
+	  The module will be called mlx4_fc
+
 config SCSI_DMX3191D
 	tristate "DMX3191D SCSI support"
 	depends on PCI && SCSI
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 2a3fca2..0d0dab7 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
 obj-$(CONFIG_LIBFCOE)		+= fcoe/
 obj-$(CONFIG_FCOE)		+= fcoe/
 obj-$(CONFIG_FCOE_FNIC)		+= fnic/
+obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
+obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
 obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
 obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
 obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o
-- 
1.6.3.3


[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
ewg mailing list
ewg-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers
  2010-08-16 22:17 [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers Vu Pham
@ 2010-08-16 23:51 ` Randy Dunlap
       [not found]   ` <20100816165137.d006efd0.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2010-08-16 23:51 UTC (permalink / raw)
  To: Vu Pham; +Cc: Roland Dreier, OpenFabrics EWG, Linux RDMA, Linux SCSI

On Mon, 16 Aug 2010 15:17:05 -0700 Vu Pham wrote:

>  {hm, no text to reply to;  oh, the patch is an attachment; please don't do that}


(copy-paste here:)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 158284f..3573cee 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -687,6 +687,28 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	depends on MLX4_EN

	depends on 
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
+	  The module will be called mlx4_fc

End both lines above with periods (".").

+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module FIP-alike to discover BridgeX gateways in the
+	  Infiniband fabric

end sentence with ".".

What does "FIP-alike" mean?  and fix grammar:

	  This module attempts to discover BridgeX gateways in the
	  Infiniband fabric.
?


+	  The module will be called mlx4_fc
+

end sentence with ".".


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers
       [not found]   ` <20100816165137.d006efd0.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
@ 2010-08-18 16:55     ` Vu Pham
  2010-08-18 17:05       ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Vu Pham @ 2010-08-18 16:55 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: Linux RDMA, Roland Dreier, OpenFabrics EWG, Linux SCSI, Oren Duer


> 	depends on 
> +	select LIBFC
> +	select LIBFCOE
> +	help
> +	  Fibre Channel over Ethernet/Infiniband module
> +
> +	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
> +	  The module will be called mlx4_fc
> 
> End both lines above with periods (".").
> 
> +
> +	  The module FIP-alike to discover BridgeX gateways in the
> +	  Infiniband fabric
> 
> end sentence with ".".
> 
> What does "FIP-alike" mean?  and fix grammar:
> 
> 	  This module attempts to discover BridgeX gateways in the
> 	  Infiniband fabric.
> ?

> 
> end sentence with ".".

Thanks for you comments.

>From 54041f56fa1896388a52f503e43e21aa11cc9a2a Mon Sep 17 00:00:00 2001
From: Vu Pham <vu-OnC3O1emZK9LiOotz6YBiwC/G2K4zDHf@public.gmane.org>
Date: Tue, 17 Aug 2010 15:40:42 -0700
Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers

Add entries in scsi's Kconfig and Makefile to enable mlx4_fc
(fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery
driver)

Signed-off-by: Vu Pham <vu-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/scsi/Kconfig  |   23 +++++++++++++++++++++++
 drivers/scsi/Makefile |    2 ++
 2 files changed, 25 insertions(+), 0 deletions(-)

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 158284f..e3d2850 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -687,6 +687,29 @@ config FCOE_FNIC
 	  <file:Documentation/scsi/scsi.txt>.
 	  The module will be called fnic.
 
+config MLX4_FC
+	tristate "Mellanox FC module"
+	select MLX4_EN
+	select LIBFC
+	select LIBFCOE
+	help
+	  Fibre Channel over Ethernet/Infiniband module
+
+	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs.
+	  The module will be called mlx4_fc.
+
+config MLX4_FCOIB
+	tristate "Mellanox FCoIB discovery module"
+	depends on INFINIBAND
+	select MLX4_FC
+	help
+	  Fibre Channel over Infiniband discovery module
+
+	  The module attempts to discover BridgeX gateways in the
+	  Infiniband fabric by implementing FIP protocol (FCoE
+	  Initialization protocol) over Infiniband.
+	  The module will be called mlx4_fcoib.
+
 config SCSI_DMX3191D
 	tristate "DMX3191D SCSI support"
 	depends on PCI && SCSI
diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
index 2a3fca2..0d0dab7 100644
--- a/drivers/scsi/Makefile
+++ b/drivers/scsi/Makefile
@@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
 obj-$(CONFIG_LIBFCOE)		+= fcoe/
 obj-$(CONFIG_FCOE)		+= fcoe/
 obj-$(CONFIG_FCOE_FNIC)		+= fnic/
+obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
+obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
 obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
 obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
 obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o
-- 
1.6.3.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers
  2010-08-18 16:55     ` Vu Pham
@ 2010-08-18 17:05       ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-08-18 17:05 UTC (permalink / raw)
  To: Vu Pham; +Cc: Roland Dreier, OpenFabrics EWG, Linux RDMA, Linux SCSI, Oren Duer

On 08/18/10 09:55, Vu Pham wrote:
> 
>> 	depends on 
>> +	select LIBFC
>> +	select LIBFCOE
>> +	help
>> +	  Fibre Channel over Ethernet/Infiniband module
>> +
>> +	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs
>> +	  The module will be called mlx4_fc
>>
>> End both lines above with periods (".").
>>
>> +
>> +	  The module FIP-alike to discover BridgeX gateways in the
>> +	  Infiniband fabric
>>
>> end sentence with ".".
>>
>> What does "FIP-alike" mean?  and fix grammar:
>>
>> 	  This module attempts to discover BridgeX gateways in the
>> 	  Infiniband fabric.
>> ?
> 
>>
>> end sentence with ".".
> 
> Thanks for you comments.
> 
> From 54041f56fa1896388a52f503e43e21aa11cc9a2a Mon Sep 17 00:00:00 2001
> From: Vu Pham <vu@vu-lt.mti.mtl.com>
> Date: Tue, 17 Aug 2010 15:40:42 -0700
> Subject: [PATCH 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers
> 
> Add entries in scsi's Kconfig and Makefile to enable mlx4_fc
> (fcoe/fcoib offload driver) and mlx4_fcoib (FIP-alike discovery
> driver)
> 
> Signed-off-by: Vu Pham <vu@mellanox.com>

Looks good.  Thanks for the update.

> ---
>  drivers/scsi/Kconfig  |   23 +++++++++++++++++++++++
>  drivers/scsi/Makefile |    2 ++
>  2 files changed, 25 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 158284f..e3d2850 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -687,6 +687,29 @@ config FCOE_FNIC
>  	  <file:Documentation/scsi/scsi.txt>.
>  	  The module will be called fnic.
>  
> +config MLX4_FC
> +	tristate "Mellanox FC module"
> +	select MLX4_EN
> +	select LIBFC
> +	select LIBFCOE
> +	help
> +	  Fibre Channel over Ethernet/Infiniband module
> +
> +	  This is support for the Mellanox ConnectX/ConnectX-2 HCAs.
> +	  The module will be called mlx4_fc.
> +
> +config MLX4_FCOIB
> +	tristate "Mellanox FCoIB discovery module"
> +	depends on INFINIBAND
> +	select MLX4_FC
> +	help
> +	  Fibre Channel over Infiniband discovery module
> +
> +	  The module attempts to discover BridgeX gateways in the
> +	  Infiniband fabric by implementing FIP protocol (FCoE
> +	  Initialization protocol) over Infiniband.
> +	  The module will be called mlx4_fcoib.
> +
>  config SCSI_DMX3191D
>  	tristate "DMX3191D SCSI support"
>  	depends on PCI && SCSI
> diff --git a/drivers/scsi/Makefile b/drivers/scsi/Makefile
> index 2a3fca2..0d0dab7 100644
> --- a/drivers/scsi/Makefile
> +++ b/drivers/scsi/Makefile
> @@ -40,6 +40,8 @@ obj-$(CONFIG_LIBFC)		+= libfc/
>  obj-$(CONFIG_LIBFCOE)		+= fcoe/
>  obj-$(CONFIG_FCOE)		+= fcoe/
>  obj-$(CONFIG_FCOE_FNIC)		+= fnic/
> +obj-$(CONFIG_MLX4_FC)		+= mlx4_fc/
> +obj-$(CONFIG_MLX4_FCOIB)	+= mlx4_fc/
>  obj-$(CONFIG_ISCSI_TCP) 	+= libiscsi.o	libiscsi_tcp.o iscsi_tcp.o
>  obj-$(CONFIG_INFINIBAND_ISER) 	+= libiscsi.o
>  obj-$(CONFIG_SCSI_A4000T)	+= 53c700.o	a4000t.o


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2010-08-18 17:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-16 22:17 [PATCH v1 10/10] mlx4_fc: Enable FC over Ethernet/Infiniband drivers Vu Pham
2010-08-16 23:51 ` Randy Dunlap
     [not found]   ` <20100816165137.d006efd0.randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2010-08-18 16:55     ` Vu Pham
2010-08-18 17:05       ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).