* Re: linux-next: Tree for October 12 (scsi/bfa)
[not found] <20101012163552.7306165b.sfr@canb.auug.org.au>
@ 2010-10-12 17:14 ` Randy Dunlap
2010-10-12 17:15 ` Randy Dunlap
2010-10-12 22:44 ` Jing Huang
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-10-12 17:14 UTC (permalink / raw)
To: Stephen Rothwell, scsi; +Cc: linux-next, LKML, Jing Huang
On Tue, 12 Oct 2010 16:35:52 +1100 Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20101011:
bfa has one function that probably uses too much stack space and a few
others that might be a problem.
With CONFIG_FRAME_WARN=1024:
drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 1024 bytes
and with CONFIG_FRAME_WARN=512:
drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg':
drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512 bytes
drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds':
drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 512 bytes
drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init':
drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than 512 bytes
drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_portattr_block':
drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger than 512 bytes
drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld':
drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger than 512 bytes
Also, there are many comment blocks that begin with "/**", which means "beginning
of kernel-doc comment block" for Linux kernel code. :(
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for October 12 (scsi/bfa)
2010-10-12 17:14 ` linux-next: Tree for October 12 (scsi/bfa) Randy Dunlap
@ 2010-10-12 17:15 ` Randy Dunlap
2010-10-12 22:44 ` Jing Huang
1 sibling, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-10-12 17:15 UTC (permalink / raw)
To: Stephen Rothwell, scsi; +Cc: linux-next, LKML, Jing Huang
On 10/12/10 10:14, Randy Dunlap wrote:
> On Tue, 12 Oct 2010 16:35:52 +1100 Stephen Rothwell wrote:
>
>> Hi all,
>>
>> Changes since 20101011:
>
>
> bfa has one function that probably uses too much stack space and a few
> others that might be a problem.
>
> With CONFIG_FRAME_WARN=1024:
>
> drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 1024 bytes
BTW, these are on i386 builds.
> and with CONFIG_FRAME_WARN=512:
>
>
> drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg':
> drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds':
> drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init':
> drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_portattr_block':
> drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger than 512 bytes
> drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld':
> drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger than 512 bytes
>
>
> Also, there are many comment blocks that begin with "/**", which means "beginning
> of kernel-doc comment block" for Linux kernel code. :(
>
> ---
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: linux-next: Tree for October 12 (scsi/bfa)
2010-10-12 17:14 ` linux-next: Tree for October 12 (scsi/bfa) Randy Dunlap
2010-10-12 17:15 ` Randy Dunlap
@ 2010-10-12 22:44 ` Jing Huang
1 sibling, 0 replies; 4+ messages in thread
From: Jing Huang @ 2010-10-12 22:44 UTC (permalink / raw)
To: Randy Dunlap, Stephen Rothwell, scsi
Cc: linux-next@vger.kernel.org, LKML, Krishna Gudipati, Maggie Zhang
>bfa has one function that probably uses too much stack space and a few
>others that might be a problem.
>
>With CONFIG_FRAME_WARN=1024:
>
>drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than
>1024 bytes
>
>and with CONFIG_FRAME_WARN=512:
>
>
>drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg':
>drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512
>bytes
>drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds':
>drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than
>512 bytes
>drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init':
>drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than
>512 bytes
>drivers/scsi/bfa/bfa_fcs_lport.c: In function
>'bfa_fcs_lport_fdmi_build_portattr_block':
>drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger
>than 512 bytes
>drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld':
>drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger
>than 512 bytes
>
For these specific cases, we declare some big data structures in the stack, which is not good
and I will fix them. But is general, is passing 512 stack size check a requirement? This seems
too strict for me since the default stack size is 8k.
>Also, there are many comment blocks that begin with "/**", which means "beginning
>of kernel-doc comment block" for Linux kernel code. :(
>
Not aware of this convention. I will fix them. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: linux-next: Tree for October 12 (scsi/bfa)
@ 2010-10-12 22:55 Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2010-10-12 22:55 UTC (permalink / raw)
To: huangj; +Cc: sfr, linux-scsi, kgudipat, linux-kernel, xmzhang, linux-next
Hi,
>bfa has one function that probably uses too much stack space and a few
>others that might be a problem.
>
>With CONFIG_FRAME_WARN=1024:
>
>drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than
>1024 bytes
>
>and with CONFIG_FRAME_WARN=512:
>
>
>drivers/scsi/bfa/bfad.c: In function 'bfad_fcs_port_cfg':
>drivers/scsi/bfa/bfad.c:900: warning: the frame size of 676 bytes is larger than 512
>bytes
>drivers/scsi/bfa/bfad_im.c: In function 'bfad_im_supported_speeds':
>drivers/scsi/bfa/bfad_im.c:939: warning: the frame size of 1604 bytes is larger than
>512 bytes
>drivers/scsi/bfa/bfad_im.c: In function 'bfad_os_fc_host_init':
>drivers/scsi/bfa/bfad_im.c:976: warning: the frame size of 736 bytes is larger than
>512 bytes
>drivers/scsi/bfa/bfa_fcs_lport.c: In function
>'bfa_fcs_lport_fdmi_build_portattr_block':
>drivers/scsi/bfa/bfa_fcs_lport.c:2010: warning: the frame size of 572 bytes is larger
>than 512 bytes
>drivers/scsi/bfa/bfa_fcs_lport.c: In function 'bfa_fcs_lport_fdmi_build_rhba_pyld':
>drivers/scsi/bfa/bfa_fcs_lport.c:1803: warning: the frame size of 784 bytes is larger
>than 512 bytes
>
| For these specific cases, we declare some big data structures in the stack, which is not good
| and I will fix them. But is general, is passing 512 stack size check a requirement? This seems
| too strict for me since the default stack size is 8k.
Fixing the warnings for frame size exceeding 1024 is OK IMO.
The 512 test was just for more info.
Ah, I see, 8 KB stack is default on X86_32.
>Also, there are many comment blocks that begin with "/**", which means "beginning
>of kernel-doc comment block" for Linux kernel code. :(
>
| Not aware of this convention. I will fix them. Thanks.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-12 22:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20101012163552.7306165b.sfr@canb.auug.org.au>
2010-10-12 17:14 ` linux-next: Tree for October 12 (scsi/bfa) Randy Dunlap
2010-10-12 17:15 ` Randy Dunlap
2010-10-12 22:44 ` Jing Huang
2010-10-12 22:55 Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox