linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Linux SCSI List <linux-scsi@vger.kernel.org>,
	James Bottomley <James.Bottomley@suse.de>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/2] scsi: remove bogus use of struct execute_work in sg
Date: Tue, 19 Oct 2010 14:57:36 +0200	[thread overview]
Message-ID: <4CBD95C0.6060302@kernel.org> (raw)

execute_work usage in sg is bogus.  execute_in_process_context() is
never used and ew is used purely as wrapper around work_struct which
is superflous.  Use work_struct directly.

Signed-off-by: Tejun Heo <tj@kernel.org>
---
 drivers/scsi/sg.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Index: work/drivers/scsi/sg.c
===================================================================
--- work.orig/drivers/scsi/sg.c
+++ work/drivers/scsi/sg.c
@@ -137,7 +137,7 @@ typedef struct sg_request {	/* SG_MAX_QU
 	volatile char done;	/* 0->before bh, 1->before read, 2->read */
 	struct request *rq;
 	struct bio *bio;
-	struct execute_work ew;
+	struct work_struct work;
 } Sg_request;

 typedef struct sg_fd {		/* holds the state of a file descriptor */
@@ -160,7 +160,7 @@ typedef struct sg_fd {		/* holds the sta
 	char keep_orphan;	/* 0 -> drop orphan (def), 1 -> keep for read() */
 	char mmap_called;	/* 0 -> mmap() never called on this fd */
 	struct kref f_ref;
-	struct execute_work ew;
+	struct work_struct work;
 } Sg_fd;

 typedef struct sg_device { /* holds the state of each scsi generic device */
@@ -1246,7 +1246,7 @@ sg_mmap(struct file *filp, struct vm_are

 static void sg_rq_end_io_usercontext(struct work_struct *work)
 {
-	struct sg_request *srp = container_of(work, struct sg_request, ew.work);
+	struct sg_request *srp = container_of(work, struct sg_request, work);
 	struct sg_fd *sfp = srp->parentfp;

 	sg_finish_rem_req(srp);
@@ -1333,8 +1333,8 @@ static void sg_rq_end_io(struct request
 		kill_fasync(&sfp->async_qp, SIGPOLL, POLL_IN);
 		kref_put(&sfp->f_ref, sg_remove_sfp);
 	} else {
-		INIT_WORK(&srp->ew.work, sg_rq_end_io_usercontext);
-		schedule_work(&srp->ew.work);
+		INIT_WORK(&srp->work, sg_rq_end_io_usercontext);
+		schedule_work(&srp->work);
 	}
 }

@@ -2086,7 +2086,7 @@ sg_add_sfp(Sg_device * sdp, int dev)

 static void sg_remove_sfp_usercontext(struct work_struct *work)
 {
-	struct sg_fd *sfp = container_of(work, struct sg_fd, ew.work);
+	struct sg_fd *sfp = container_of(work, struct sg_fd, work);
 	struct sg_device *sdp = sfp->parentdp;

 	/* Cleanup any responses which were never read(). */
@@ -2123,8 +2123,8 @@ static void sg_remove_sfp(struct kref *k
 	write_unlock_irqrestore(&sg_index_lock, iflags);
 	wake_up_interruptible(&sdp->o_excl_wait);

-	INIT_WORK(&sfp->ew.work, sg_remove_sfp_usercontext);
-	schedule_work(&sfp->ew.work);
+	INIT_WORK(&sfp->work, sg_remove_sfp_usercontext);
+	schedule_work(&sfp->work);
 }

 static int

             reply	other threads:[~2010-10-19 12:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-19 12:57 Tejun Heo [this message]
2010-10-19 12:58 ` [PATCH 2/2] scsi: don't use execute_in_process_context() Tejun Heo
2010-10-22 10:03   ` FUJITA Tomonori
2010-12-12 22:48   ` James Bottomley
2010-12-14  9:53     ` Tejun Heo
2010-12-14 14:09       ` James Bottomley
2010-12-14 14:19         ` Tejun Heo
2010-12-14 14:26           ` James Bottomley
2010-12-14 14:33             ` Tejun Heo
2010-12-15  3:04               ` James Bottomley
2010-12-15 15:47                 ` Tejun Heo
2010-12-15 15:54                   ` James Bottomley
2010-12-15 16:00                     ` Tejun Heo
2010-12-15 17:22                       ` James Bottomley
2010-12-15 19:05                         ` Tejun Heo
2010-12-15 19:10                           ` James Bottomley
2010-12-15 19:19                             ` Tejun Heo
2010-12-15 19:33                               ` James Bottomley
2010-12-15 19:42                                 ` Tejun Heo
2010-12-15 19:46                                   ` Tejun Heo
2010-12-16 14:39                                   ` James Bottomley
2010-12-16 15:51                                     ` Tejun Heo
2010-12-15 19:34                               ` Tejun Heo
2010-10-20 14:29 ` [PATCH 1/2] scsi: remove bogus use of struct execute_work in sg FUJITA Tomonori
2010-10-20 19:56 ` Douglas Gilbert
  -- strict thread matches above, loose matches on Subject: below --
2011-01-24 13:31 Tejun Heo
2011-02-01 10:58 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBD95C0.6060302@kernel.org \
    --to=tj@kernel.org \
    --cc=James.Bottomley@suse.de \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).