From: Joe Eykholt <jeykholt@cisco.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: Rob Evers <revers@redhat.com>, Jing Huang <huangj@brocade.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 3/6] bfa: remove os wrapper functions and macros
Date: Wed, 20 Oct 2010 16:04:09 -0700 [thread overview]
Message-ID: <4CBF7569.90708@cisco.com> (raw)
In-Reply-To: <4CBF6A38.7060502@cs.wisc.edu>
On 10/20/10 3:16 PM, Mike Christie wrote:
> On 10/20/2010 10:25 AM, Rob Evers wrote:
>> Is scsi_for_each_sg() use pretty standard for mass storage drivers these
>> days?
>
> Yes, the driver should be using it.
>
>>
>> Is the byte swapping required if the more traditional sg implementation
>> is used?
>>
>>>
>>> #ifndef __BIGENDIAN
>>> -#define bfa_os_hton3b(_x) bfa_swap_3b(_x)
>>> +#define bfa_os_hton3b(_x) bfa_swap_3b(_x)
>>
>> Should bfa_os_hton3b and related functionality be relocated
>> appropriately and implemented in common form to the other common byte
>> swapping code?
>>
>
> Yes. I think intel was working on that for fcoe. Someone should dig up the patches and finish pushing.
It's in <scsi/fc_frame.h> as hton24() / ntoh24(). It's written in
an endian-independent way. I don't know of patches to move them to
a better place.
Joe
next prev parent reply other threads:[~2010-10-20 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 0:12 [PATCH 3/6] bfa: remove os wrapper functions and macros Jing Huang
2010-10-20 15:25 ` Rob Evers
2010-10-20 22:16 ` Mike Christie
2010-10-20 23:04 ` Joe Eykholt [this message]
2010-10-20 23:16 ` Jing Huang
2010-10-20 23:50 ` Mike Christie
2010-10-20 23:48 ` Jing Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBF7569.90708@cisco.com \
--to=jeykholt@cisco.com \
--cc=huangj@brocade.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=revers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).