From: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
To: Robert Love <robert.w.love-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Hillf Danton <dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devel-s9riP+hp16TNLxjTenLetw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] libfc: fix mem leak in fc_tm_done()
Date: Wed, 27 Oct 2010 20:55:09 -0500 [thread overview]
Message-ID: <4CC8D7FD.3070608@cs.wisc.edu> (raw)
In-Reply-To: <1288229055.1431.46.camel@fritz>
On 10/27/2010 08:24 PM, Robert Love wrote:
> On Mon, 2010-10-25 at 20:37 +0800, Hillf Danton wrote:
>> There seems frame should get freed against memory leakage.
>>
>> Signed-off-by: Hillf Danton<dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>
>> --- a/drivers/scsi/libfc/fc_fcp.c 2010-09-13 07:07:38.000000000 +0800
>> +++ b/drivers/scsi/libfc/fc_fcp.c 2010-10-25 20:31:04.000000000 +0800
>> @@ -1294,6 +1294,7 @@ static void fc_tm_done(struct fc_seq *se
>> */
>> if (!fsp->seq_ptr || !fsp->wait_for_comp) {
>> spin_unlock_bh(&fsp->scsi_pkt_lock);
>
> I wonder if this should be a fc_fcp_unlock_pkt(fsp) since we get the
> lock with the fc_fcp_lock_pkt(fsp) call above.
>
Did I do that. I think you are right. Not sure what happened if it was me.
next prev parent reply other threads:[~2010-10-28 1:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 12:37 [PATCH 1/2] libfc: fix mem leak in fc_tm_done() Hillf Danton
2010-10-25 12:42 ` [PATCH 2/2] " Hillf Danton
2010-10-28 1:18 ` [Open-FCoE] [PATCH 1/2] " Robert Love
2010-10-28 13:47 ` Hillf Danton
[not found] ` <AANLkTinAOy9+WPuKGro09Cu=xiLF+QMQ+JkioHNZao9n-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-10-28 1:24 ` Robert Love
2010-10-28 1:55 ` Mike Christie [this message]
2010-10-28 13:43 ` [Open-FCoE] " Hillf Danton
2010-10-28 14:56 ` Zou, Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC8D7FD.3070608@cs.wisc.edu \
--to=michaelc-hcno3ddehluvc3sceru5cw@public.gmane.org \
--cc=devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
--cc=dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robert.w.love-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).