Re: Full hostlock pushdown available

Jeff Garzik
2010-11-01T15:56:51Z

On 11/01/2010 09:53 AM, Andi Kleen wrote:
>> > Missing drivers/ata/libata-scsi.c modification?

> Ah thanks for noticing. I missed that because it defined queuecommand
> in a header plus a macro. Fixed in the tree. I also did another grep to make
> sure there a no other occurrences. And fixed some documentation.
>
> Updated tree

You have just recreated the same bug Nicholas did: you incorrectly
removed the required _irqsave and _irqrestore from ap->lock.

Please check your changes closely to make sure you haven't duplicated
this bug in other drivers.

This is _precisely_ why I like Boaz' suggestion: it better guarantees
the locking remains unchanged. Apparently your change, like Nicholas's,
is not so mechanical after all.

Jeff