From: Boaz Harrosh <bharrosh@panasas.com>
To: James Bottomley <James.Bottomley@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Jeff Garzik <jeff@garzik.org>
Cc: Christoph Hellwig <hch@infradead.org>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: [PATCH 0/3] scsi_lib: Some love to scsi_lib
Date: Mon, 08 Nov 2010 17:02:18 +0200 [thread overview]
Message-ID: <4CD810FA.902@panasas.com> (raw)
Submitted a much needed cleanup to scsi_lib's command completion
path. The code after these patches should theoretically be
behaviour equivalent to current code. Only cleaner smaller, and
easier to understand. The motivation was to make things clearer
to understand. It was all inspired by Alan Stern and more things
added to that.
Theoretically, since I have only tested with the usual tests I have.
Boot an x86_64 machine, git clone, make, xfstests ...
I did not run any Error injection tests with scsi_debug, since I don't
have any set up. Though one should because the error handling might
have changed accidentally, though not intended.
Please someone, Alan Jeff ... I have tried to go through every possible
code path and prove that we do exactly as before. But I might have missed
something. Please check my Math.
I'm sitting on these patches since 2.6.34-rc4, but never followed
them through, and tested them. Sorry. They patched without any issues
on top of current scsi-misc meaning nothing changed in this area since a
long time.
The patches are:
[PATCH 1/3] scsi_lib: request_queue is only needed inside scsi_requeue_command
[PATCH 2/3] scsi_lib: Remove that __scsi_release_buffers contraption
These two are pure and trivial
[PATCH 3/3] scsi_lib: Collapse scsi_end_request into only user
This one should be reviewed, but should not change any
behaviour.
Thanks
Boaz
next reply other threads:[~2010-11-08 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 15:02 Boaz Harrosh [this message]
2010-11-08 15:10 ` [PATCH 1/3] scsi_lib: request_queue is only needed inside scsi_requeue_command Boaz Harrosh
2010-11-08 15:11 ` [PATCH 2/3] scsi_lib: Remove that __scsi_release_buffers contraption Boaz Harrosh
2010-11-08 15:15 ` [PATCH 3/3] scsi_lib: Collapse scsi_end_request into only user Boaz Harrosh
2010-11-08 16:18 ` [PATCH] scsi_lib: BUG: Can't RETRY scsi_cmnd if some bytes were completed Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD810FA.902@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@suse.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox