From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
James Bottomley <James.Bottomley@suse.de>,
"Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1
Date: Sat, 13 Nov 2010 00:26:49 -0500 [thread overview]
Message-ID: <4CDE2199.7080309@garzik.org> (raw)
In-Reply-To: <AANLkTik_eXv1_ZaqD01CoT6igzjBZtmECD0e+QUkMhxP@mail.gmail.com>
On 11/12/2010 11:42 PM, Linus Torvalds wrote:
> Having to inevitably do that silly double dereference
> ("cmd->device->host") seems bogus. Passing in the host you want to
> queue something on seems to be natural, and avoids that nasty chain of
> dereferences, so it really should improve the code.
As noted in the patch v4, just sent, I agree.
> So the shost pointer is certainly a lot more useful than the 'done'
> function pointer. So yeah, I'd switch them around - pass the 'done'
> thing indirectly, and the shost directly.
You bozos would come up with this the _minute_ I sent my patch, eh? :)
IMO, the 'done' removal should be in a separate patch from the host lock
push-down.
It should be straightforward, if applied immediately following the
push-down patch. bisect remains clean.
Jeff
next prev parent reply other threads:[~2010-11-13 5:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 23:55 [GIT PULL] SCSI queuecommand API change for 2.6.37-rc1 James Bottomley
2010-11-13 0:38 ` Nicholas A. Bellinger
2010-11-13 1:42 ` Linus Torvalds
2010-11-13 2:03 ` Jeff Garzik
2010-11-13 2:09 ` Jeff Garzik
2010-11-13 2:30 ` Linus Torvalds
2010-11-13 4:28 ` Matthew Wilcox
2010-11-13 4:42 ` Linus Torvalds
2010-11-13 5:26 ` Jeff Garzik [this message]
2010-11-13 6:01 ` James Bottomley
2010-11-13 6:07 ` Jeff Garzik
2010-11-13 7:18 ` Nicholas A. Bellinger
2010-11-16 6:57 ` Jeff Garzik
2010-11-16 7:08 ` Jeff Garzik
2010-11-13 5:16 ` [PATCH v4] SCSI host lock push-down Jeff Garzik
2010-11-13 6:01 ` Jeff Garzik
2010-11-16 7:10 ` [PATCH v5] " Jeff Garzik
2010-11-16 7:31 ` Jeff Garzik
2010-11-16 17:25 ` Linus Torvalds
2010-11-16 17:36 ` James Bottomley
2010-11-16 21:30 ` Linus Torvalds
2010-11-16 21:32 ` James Bottomley
2010-11-16 21:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDE2199.7080309@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=nab@linux-iscsi.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox