From: Boaz Harrosh <bharrosh@panasas.com>
To: Dan Carpenter <error27@gmail.com>,
"James E.J. Bottomley" <James.Bottomley@suse.de>
Cc: Benny Halevy <bhalevy@panasas.com>,
osd-dev@open-osd.org, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] scsi/osd: checking NULL instead of ERR_PTR()
Date: Sun, 14 Nov 2010 15:39:53 +0200 [thread overview]
Message-ID: <4CDFE6A9.10704@panasas.com> (raw)
In-Reply-To: <20101112043146.GC3533@bicker>
On 11/12/2010 06:31 AM, Dan Carpenter wrote:
> bio_map_kern() returns ERR_PTRs on failure and never returns NULL.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
Acked-by: Boaz Harrosh <bharrosh@panasas.com>
> diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
> index 0433ea6..b798919 100644
> --- a/drivers/scsi/osd/osd_initiator.c
> +++ b/drivers/scsi/osd/osd_initiator.c
> @@ -951,8 +951,8 @@ static int _osd_req_finalize_cdb_cont(struct osd_request *or, const u8 *cap_key)
> /* create a bio for continuation segment */
> bio = bio_map_kern(req_q, or->cdb_cont.buff, or->cdb_cont.total_bytes,
> GFP_KERNEL);
> - if (unlikely(!bio))
> - return -ENOMEM;
> + if (unlikely(IS_ERR(bio)))
> + return PTR_ERR(bio);
>
> bio->bi_rw |= REQ_WRITE;
>
Wahoo, good catch, thanks! This is new code in 2.6.37-rc1. It should be pushed
for current Kernel.
James: please apply to scsi-rc-fixes for the next round of fixes?
Thanks
Boaz
next prev parent reply other threads:[~2010-11-14 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-12 4:31 [patch] scsi/osd: checking NULL instead of ERR_PTR() Dan Carpenter
2010-11-14 13:39 ` Boaz Harrosh [this message]
2010-11-21 10:31 ` Boaz Harrosh
2010-11-30 10:22 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDFE6A9.10704@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@suse.de \
--cc=bhalevy@panasas.com \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=osd-dev@open-osd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox