public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] target: rename Kbuild files to Makefile
Date: Tue, 16 Nov 2010 12:32:47 +0200	[thread overview]
Message-ID: <4CE25DCF.30408@panasas.com> (raw)
In-Reply-To: <1289854531.22107.117.camel@haakon2.linux-iscsi.org>

On 11/15/2010 10:55 PM, Nicholas A. Bellinger wrote:
> On Mon, 2010-11-15 at 12:32 -0800, Nicholas A. Bellinger wrote:
>> On Mon, 2010-11-15 at 14:43 -0500, Christoph Hellwig wrote:
>>> Signed-off-by: Christoph Hellwig <hch@lst.de>
>>>
>>
>> I was under the impression that $(srcdir)/Kbuild was the preferred
>> modern name..?
>>
> 
> This is in fact mainline convention, commited as 9093542.
> 
> Thanks!
> 
> --nab

[Rant below please ignore]

>From Documentation/kbuild/makefiles.txt

  === 3 The kbuild files

  Most Makefiles within the kernel are kbuild Makefiles that use the
  kbuild infrastructure. This chapter introduces the syntax used in the
  kbuild makefiles.
  The preferred name for the kbuild files are 'Makefile' but 'Kbuild' can
  be used and if both a 'Makefile' and a 'Kbuild' file exists, then the 'Kbuild'
  file will be used.

This has changed since the time I started. Back then that text was:
  The preferred name for the kbuild files are Kbuild

If I go to a random subdirectory in the Kernel and do:
[drivers/foo]$ make
With a Kbuild file it outputs:
make: *** No targets specified and no makefile found.  Stop.

With a Makefile it outputs:
make: *** No targets.  Stop.

Sigh! For me a "Makefile" is a make's makefile. Kbuild files are
not makefiles and should not be named as one.

But that's a lost cause
Boaz

      reply	other threads:[~2010-11-16 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 19:43 [PATCH 2/2] target: rename Kbuild files to Makefile Christoph Hellwig
2010-11-15 20:32 ` Nicholas A. Bellinger
2010-11-15 20:55   ` Nicholas A. Bellinger
2010-11-16 10:32     ` Boaz Harrosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CE25DCF.30408@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox