* Re: linux-next: Tree for December 28 (drivers/target/)
[not found] <20101228173049.217c192d.sfr@canb.auug.org.au>
@ 2010-12-28 16:29 ` Randy Dunlap
2010-12-28 16:39 ` James Bottomley
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2010-12-28 16:29 UTC (permalink / raw)
To: Stephen Rothwell, nab, scsi; +Cc: linux-next, LKML
On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
> Hi all,
>
> [The mirroring on kernel.org is running slowly]
>
> Changes since 20101227:
warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
from:
menuconfig TARGET_CORE
tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
select CONFIGFS_FS
but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
or (eek) it should select SYSFS.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for December 28 (drivers/target/)
2010-12-28 16:29 ` linux-next: Tree for December 28 (drivers/target/) Randy Dunlap
@ 2010-12-28 16:39 ` James Bottomley
2010-12-28 16:50 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: James Bottomley @ 2010-12-28 16:39 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Stephen Rothwell, nab, scsi, linux-next, LKML
On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote:
> On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
>
> > Hi all,
> >
> > [The mirroring on kernel.org is running slowly]
> >
> > Changes since 20101227:
>
>
> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
>
> from:
>
> menuconfig TARGET_CORE
> tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
> select CONFIGFS_FS
>
> but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
> or (eek) it should select SYSFS.
The latter, I think (and actually, configfs should select sysfs). All
these unmet dependencies are a minefield.
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for December 28 (drivers/target/)
2010-12-28 16:39 ` James Bottomley
@ 2010-12-28 16:50 ` Randy Dunlap
2010-12-28 19:38 ` Nicholas A. Bellinger
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2010-12-28 16:50 UTC (permalink / raw)
To: James Bottomley; +Cc: Stephen Rothwell, nab, scsi, linux-next, LKML
On Tue, 28 Dec 2010 10:39:14 -0600 James Bottomley wrote:
> On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote:
> > On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
> >
> > > Hi all,
> > >
> > > [The mirroring on kernel.org is running slowly]
> > >
> > > Changes since 20101227:
> >
> >
> > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
> >
> > from:
> >
> > menuconfig TARGET_CORE
> > tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
> > select CONFIGFS_FS
> >
> > but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
> > or (eek) it should select SYSFS.
>
> The latter, I think (and actually, configfs should select sysfs). All
> these unmet dependencies are a minefield.
It's just another language to deal with. Not a big deal, except for the
twists that EXPERIMENTAL injects into it.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for December 28 (drivers/target/)
2010-12-28 16:50 ` Randy Dunlap
@ 2010-12-28 19:38 ` Nicholas A. Bellinger
2010-12-28 20:04 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: Nicholas A. Bellinger @ 2010-12-28 19:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: James Bottomley, Stephen Rothwell, scsi, linux-next, LKML,
Joel Becker
On Tue, 2010-12-28 at 08:50 -0800, Randy Dunlap wrote:
> On Tue, 28 Dec 2010 10:39:14 -0600 James Bottomley wrote:
>
> > On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote:
> > > On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
> > >
> > > > Hi all,
> > > >
> > > > [The mirroring on kernel.org is running slowly]
> > > >
> > > > Changes since 20101227:
> > >
> > >
> > > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
> > >
> > > from:
> > >
> > > menuconfig TARGET_CORE
> > > tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
> > > select CONFIGFS_FS
> > >
> > > but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
> > > or (eek) it should select SYSFS.
> >
> > The latter, I think (and actually, configfs should select sysfs). All
> > these unmet dependencies are a minefield.
>
> It's just another language to deal with. Not a big deal, except for the
> twists that EXPERIMENTAL injects into it.
I agree with James on this one.. Attached is a patch to select SYSFS
and fix up some extra whitespace breakage. (jlbec CC'ed)
Thanks,
--nab
diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
index 13587cc..6874d75 100644
--- a/fs/configfs/Kconfig
+++ b/fs/configfs/Kconfig
@@ -1,11 +1,11 @@
config CONFIGFS_FS
tristate "Userspace-driven configuration filesystem"
- depends on SYSFS
+ select SYSFS
help
- configfs is a ram-based filesystem that provides the converse
- of sysfs's functionality. Where sysfs is a filesystem-based
- view of kernel objects, configfs is a filesystem-based manager
- of kernel objects, or config_items.
+ configfs is a ram-based filesystem that provides the converse
+ of sysfs's functionality. Where sysfs is a filesystem-based
+ view of kernel objects, configfs is a filesystem-based manager
+ of kernel objects, or config_items.
- Both sysfs and configfs can and should exist together on the
- same system. One is not a replacement for the other.
+ Both sysfs and configfs can and should exist together on the
+ same system. One is not a replacement for the other.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for December 28 (drivers/target/)
2010-12-28 19:38 ` Nicholas A. Bellinger
@ 2010-12-28 20:04 ` Randy Dunlap
2010-12-28 20:13 ` Nicholas A. Bellinger
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2010-12-28 20:04 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: James Bottomley, Stephen Rothwell, scsi, linux-next, LKML,
Joel Becker
On 12/28/10 11:38, Nicholas A. Bellinger wrote:
> On Tue, 2010-12-28 at 08:50 -0800, Randy Dunlap wrote:
>> On Tue, 28 Dec 2010 10:39:14 -0600 James Bottomley wrote:
>>
>>> On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote:
>>>> On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
>>>>
>>>>> Hi all,
>>>>>
>>>>> [The mirroring on kernel.org is running slowly]
>>>>>
>>>>> Changes since 20101227:
>>>>
>>>>
>>>> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
>>>>
>>>> from:
>>>>
>>>> menuconfig TARGET_CORE
>>>> tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
>>>> select CONFIGFS_FS
>>>>
>>>> but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
>>>> or (eek) it should select SYSFS.
>>>
>>> The latter, I think (and actually, configfs should select sysfs). All
>>> these unmet dependencies are a minefield.
>>
>> It's just another language to deal with. Not a big deal, except for the
>> twists that EXPERIMENTAL injects into it.
>
> I agree with James on this one.. Attached is a patch to select SYSFS
> and fix up some extra whitespace breakage. (jlbec CC'ed)
and I am not surprised. James is a more liberal 'select'or than I am.
> Thanks,
>
> --nab
>
> diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
> index 13587cc..6874d75 100644
> --- a/fs/configfs/Kconfig
> +++ b/fs/configfs/Kconfig
> @@ -1,11 +1,11 @@
> config CONFIGFS_FS
> tristate "Userspace-driven configuration filesystem"
> - depends on SYSFS
> + select SYSFS
> help
> - configfs is a ram-based filesystem that provides the converse
> - of sysfs's functionality. Where sysfs is a filesystem-based
> - view of kernel objects, configfs is a filesystem-based manager
> - of kernel objects, or config_items.
> + configfs is a ram-based filesystem that provides the converse
RAM-based
> + of sysfs's functionality. Where sysfs is a filesystem-based
> + view of kernel objects, configfs is a filesystem-based manager
> + of kernel objects, or config_items.
>
> - Both sysfs and configfs can and should exist together on the
> - same system. One is not a replacement for the other.
> + Both sysfs and configfs can and should exist together on the
> + same system. One is not a replacement for the other.
>
>
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for December 28 (drivers/target/)
2010-12-28 20:04 ` Randy Dunlap
@ 2010-12-28 20:13 ` Nicholas A. Bellinger
0 siblings, 0 replies; 6+ messages in thread
From: Nicholas A. Bellinger @ 2010-12-28 20:13 UTC (permalink / raw)
To: Randy Dunlap
Cc: James Bottomley, Stephen Rothwell, scsi, linux-next, LKML,
Joel Becker
On Tue, 2010-12-28 at 12:04 -0800, Randy Dunlap wrote:
> On 12/28/10 11:38, Nicholas A. Bellinger wrote:
> > On Tue, 2010-12-28 at 08:50 -0800, Randy Dunlap wrote:
> >> On Tue, 28 Dec 2010 10:39:14 -0600 James Bottomley wrote:
> >>
> >>> On Tue, 2010-12-28 at 08:29 -0800, Randy Dunlap wrote:
> >>>> On Tue, 28 Dec 2010 17:30:49 +1100 Stephen Rothwell wrote:
> >>>>
> >>>>> Hi all,
> >>>>>
> >>>>> [The mirroring on kernel.org is running slowly]
> >>>>>
> >>>>> Changes since 20101227:
> >>>>
> >>>>
> >>>> warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS)
> >>>>
> >>>> from:
> >>>>
> >>>> menuconfig TARGET_CORE
> >>>> tristate "Generic Target Core Mod (TCM) and ConfigFS Infrastructure"
> >>>> select CONFIGFS_FS
> >>>>
> >>>> but CONFIGFS_FS depends on SYSFS, so TARGET_CORE should either depend on SYSFS
> >>>> or (eek) it should select SYSFS.
> >>>
> >>> The latter, I think (and actually, configfs should select sysfs). All
> >>> these unmet dependencies are a minefield.
> >>
> >> It's just another language to deal with. Not a big deal, except for the
> >> twists that EXPERIMENTAL injects into it.
> >
> > I agree with James on this one.. Attached is a patch to select SYSFS
> > and fix up some extra whitespace breakage. (jlbec CC'ed)
>
> and I am not surprised. James is a more liberal 'select'or than I am.
;)
>
> > Thanks,
> >
> > --nab
> >
> > diff --git a/fs/configfs/Kconfig b/fs/configfs/Kconfig
> > index 13587cc..6874d75 100644
> > --- a/fs/configfs/Kconfig
> > +++ b/fs/configfs/Kconfig
> > @@ -1,11 +1,11 @@
> > config CONFIGFS_FS
> > tristate "Userspace-driven configuration filesystem"
> > - depends on SYSFS
> > + select SYSFS
> > help
> > - configfs is a ram-based filesystem that provides the converse
> > - of sysfs's functionality. Where sysfs is a filesystem-based
> > - view of kernel objects, configfs is a filesystem-based manager
> > - of kernel objects, or config_items.
> > + configfs is a ram-based filesystem that provides the converse
>
> RAM-based
>
Fixed, and added as a single patch into the LIO tree tracking linux-next
here:
http://git.kernel.org/?p=linux/kernel/git/nab/linux-next.git;a=commitdiff;h=87b548329a29fbe54453f9ef47819ee39a32716d
Thanks!
--nab
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-28 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20101228173049.217c192d.sfr@canb.auug.org.au>
2010-12-28 16:29 ` linux-next: Tree for December 28 (drivers/target/) Randy Dunlap
2010-12-28 16:39 ` James Bottomley
2010-12-28 16:50 ` Randy Dunlap
2010-12-28 19:38 ` Nicholas A. Bellinger
2010-12-28 20:04 ` Randy Dunlap
2010-12-28 20:13 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).