From mboxrd@z Thu Jan 1 00:00:00 1970 From: roel kluin Subject: Re: [PATCH] [SCSI] arcmsr: &/| confusion in arcmsr_build_ccb() Date: Sat, 01 Jan 2011 19:40:23 +0100 Message-ID: <4D1F7517.7080803@gmail.com> References: <4D1F5A17.4010807@gmail.com> <20110101170854.GB32652@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110101170854.GB32652@parisc-linux.org> Sender: linux-kernel-owner@vger.kernel.org To: Matthew Wilcox , just.for.lkml@googlemail.com Cc: nick.cheng@areca.com.tw, Andrew Morton , LKML , James.Bottomley@suse.de, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Make sure no other command which does a write, such as UNMAP and WRITE_32, is missed. Signed-off-by: Roel Kluin --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) If you agree this is the right fix, please ack. diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 17e3df4..a5acedc 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++ b/drivers/scsi/arcmsr/arcmsr_hba.c @@ -1171,7 +1171,7 @@ static int arcmsr_build_ccb(struct AdapterControlBlock *acb, arcmsr_cdb->msgPages = arccdbsize/0x100 + (arccdbsize % 0x100 ? 1 : 0); if ( arccdbsize > 256) arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_SGL_BSIZE; - if (pcmd->cmnd[0]|WRITE_6 || pcmd->cmnd[0]|WRITE_10 || pcmd->cmnd[0]|WRITE_12 ){ + if (pcmd->sc_data_direction == DMA_TO_DEVICE) arcmsr_cdb->Flags |= ARCMSR_CDB_FLAG_WRITE; } ccb->arc_cdb_size = arccdbsize;