From: Jens Axboe <jaxboe@fusionio.com>
To: "ltuikov@yahoo.com" <ltuikov@yahoo.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [BLOCK] Allow tag 0 to be generated
Date: Mon, 10 Jan 2011 19:52:12 +0100 [thread overview]
Message-ID: <4D2B555C.5090109@fusionio.com> (raw)
In-Reply-To: <4D2B54CE.3080301@fusionio.com>
On 2011-01-10 19:49, Jens Axboe wrote:
> On 2011-01-10 18:26, Luben Tuikov wrote:
>> Commit 67869fb9fdfa04503b250d59e086c15f1698aea0
>
> That commit isn't a valid sha in my tree. What commit do you mean?
>
>> skipped tag 0 by virtue of setting last_tag to
>> 0. This commit sets it to -1, in order to start
>> and loop over from 0, thus generating tags
>> [0,max_tag-1], instead of [1,max_tag-1].
>
> Irregardless, patch looks good. That's definitely a bug. Thanks!
But not in my kernel, what tree are you looking at? I don't remember
seeing any tag patches, and they should be in my tree if there are.
--
Jens Axboe
next prev parent reply other threads:[~2011-01-10 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 17:26 [PATCH] [BLOCK] Allow tag 0 to be generated Luben Tuikov
2011-01-10 18:49 ` Jens Axboe
2011-01-10 18:52 ` Jens Axboe [this message]
2011-01-10 19:27 ` Luben Tuikov
2011-01-10 19:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D2B555C.5090109@fusionio.com \
--to=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).