From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomas Henzl Subject: Re: [PATCH 2/2] arcmsr: code cleanup and some corrections Date: Thu, 24 Feb 2011 15:14:59 +0100 Message-ID: <4D6667E3.7030909@redhat.com> References: <4D53F7EF.70003@redhat.com> <6BCF37FA033449599C8CB43E2D84A0B6@arecaaebe11fae> <4D5D3941.2090407@redhat.com> <20110218100400A.fujita.tomonori@lab.ntt.co.jp> <4D5E512E.6000904@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56640 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755408Ab1BXOPP (ORCPT ); Thu, 24 Feb 2011 09:15:15 -0500 In-Reply-To: <4D5E512E.6000904@redhat.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: FUJITA Tomonori Cc: nick.cheng@areca.com.tw, linux-scsi@vger.kernel.org, James.Bottomley@HansenPartnership.com Hi Nick, again thanks for your response in the 'arcmsr: code cleanup and some corrections' thread. Let us find a resolution here too. Is the original patch fine for you, or do you prefer not to take it? Tomas > On 02/18/2011 02:04 AM, FUJITA Tomonori wrote: > >> On Thu, 17 Feb 2011 16:05:37 +0100 >> Tomas Henzl wrote: >> >> >> >>> the discussion is mostly if 'dma_alloc_coherent' >>> ... >>> dma_coherent = dma_alloc_coherent(&pdev->dev, acb->uncache_size, &dma_coherent_handle, GFP_KERNEL); >>> ... >>> returns a page address - dma_coherent with last, I think five bits, zeroed. >>> Could you help us with that? >>> >>> >> Documentation/DMA-API-HOWTO.txt is not clear enough? >> >> = >> dma_alloc_coherent returns two values: the virtual address which you >> can use to access it from the CPU and dma_handle which you pass to the >> card. >> >> The cpu return address and the DMA bus master address are both >> guaranteed to be aligned to the smallest PAGE_SIZE order which >> is greater than or equal to the requested size. This invariant >> exists (for example) to guarantee that if you allocate a chunk >> which is smaller than or equal to 64 kilobytes, the extent of the >> buffer you receive will not cross a 64K boundary. >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> > It's clear enough I think, I asked this question because Nick doesn't > have a "100% confidence in that.". So I wanted a help to convince him. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >