From: Dan Williams <dan.j.williams@intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Jiang, Dave" <dave.jiang@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
David Milburn <dmilburn@redhat.com>
Subject: Re: [RFC PATCH] x86: Moving probe_roms_32 to probe_roms
Date: Fri, 25 Feb 2011 08:38:10 -0800 [thread overview]
Message-ID: <4D67DAF2.8090501@intel.com> (raw)
In-Reply-To: <1298628822.11506.21.camel@dwillia2-linux>
On 02/25/2011 02:13 AM, Williams, Dan J wrote:
[..]
> + if (probe_kernel_address(rom + offset + 0x8, list) != 0 &&
> + probe_kernel_address(rom + offset + 0xc, rev) != 0 &&
These should be "== 0", but you get the idea...
> + rev>= 3&& list&&
> + probe_list(pdev, vendor, rom + offset + list)) {
> + oprom = res;
> + break;
> + }
> + }
--
Dan
prev parent reply other threads:[~2011-02-25 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 20:16 [RFC PATCH] x86: Moving probe_roms_32 to probe_roms Dan Williams
2011-02-25 1:27 ` Dan Williams
2011-02-25 1:51 ` H. Peter Anvin
2011-02-25 10:13 ` Dan Williams
2011-02-25 16:38 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D67DAF2.8090501@intel.com \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmilburn@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).