[PATCH 0/5]: Proposal for iSCSI Network Configuration

[PATCH 0/5]: Proposal for iSCSI Network Configuration

[Vikas Chaudhary]

These are set of patches for  configuring network setting for iSCSI adapter (qla4xxx) that use private IP address.
Please review  proposal/implementation and let us know  the feedback.

iscsiadm part of proposal is submitted at open-iscsi group.
http://groups.google.com/group/open-iscsi/browse_thread/thread/2924e8d871233436

1. Current status:
Using iscsiadm one cannot do any network configuration for qla4xxx adapters.
However an iface is created for the qla4xxx ports using the hwaddress.

\# ls /etc/iscsi/ifaces/
iface.example  iface0  qla4xxx.00:0e:1e:04:8b:2a  qla4xxx.00:0e:1e:04:8b:2e. This allows user to issue sendtargets via the qla4xxx iscsi offload.

2. Current Proposal:
Current proposal is to allow iscsiadm to configure the network settings for qla4xxx ports.

This implementation is based on discussions at
http://marc.info/?l=linux-scsi&m=127066184916180&w=2
http://groups.google.com/group/open-iscsi/browse_thread/thread/d8e8c2df71c95d69/8f731d95d46141a0?lnk=gst&q=iscsi+hba#

Lalit Chandivade (2):
      [RFC] iscsi_transport: add set_net_config
      [RFC] qla4xxx: add support for set_net_config

Vikas Chaudhary (3):
      qla4xxx: Added new "struct ipaddress_config"
      [RFC] iscsi_transport: show network configuration in sysfs
      [RFC] qla4xxx: added support to show multiple iface in sysfs

drivers/scsi/qla4xxx/ql4_def.h      |   50 +++--
drivers/scsi/qla4xxx/ql4_fw.h       |  102 +++++++++
drivers/scsi/qla4xxx/ql4_glbl.h     |   13 +-
drivers/scsi/qla4xxx/ql4_init.c      |   51 +++--
drivers/scsi/qla4xxx/ql4_mbx.c    |  188 +++++++++++++---
drivers/scsi/qla4xxx/ql4_os.c        |  422 ++++++++++++++++++++++++++++++++++-
drivers/scsi/scsi_transport_iscsi.c |  246 ++++++++++++++++++++-
include/scsi/iscsi_if.h             |   53 +++++
include/scsi/scsi_transport_iscsi.h |   25 ++
9 files changed, 1073 insertions(+), 77 deletions(-)


Thanks,
Vikas.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration

[Mike Christie]

On 02/25/2011 05:05 AM, Vikas Chaudhary wrote:
> These are set of patches for  configuring network setting for iSCSI adapter (qla4xxx) that use private IP address.
> Please review  proposal/implementation and let us know  the feedback.
>

Hey,

So what happened with bsg? Why did you switch again?

-- 
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.

RE: [PATCH 0/5]: Proposal for iSCSI Network Configuration

[Vikas Chaudhary]

>-----Original Message-----
>From: open-iscsi@googlegroups.com [mailto:open-iscsi@googlegroups.com] On
>Behalf Of Mike Christie
>Sent: Monday, February 28, 2011 7:55 AM
>To: Vikas Chaudhary
>Cc: James Bottomley; linux-scsi@vger.kernel.org; Lalit Chandivade; Harish
>Zunjarrao; Manish Rangankar; Ravi Anand; open-iscsi
>Subject: Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration
>
>On 02/25/2011 05:05 AM, Vikas Chaudhary wrote:
>> These are set of patches for  configuring network setting for iSCSI
>adapter (qla4xxx) that use private IP address.
>> Please review  proposal/implementation and let us know  the feedback.
>>
>
>Hey,
>
>So what happened with bsg? Why did you switch again?

- For network configuration we found current Netlink interface to be sufficient.
- Initially we tried to implement network configuration using BSG as we needed
  all network parameters in one short from application to driver in vendor
  specific format. Now we are doing same using Netlink interface and TLV mechanism
  (vendor agnostic format)  which is scalable easily for any new network parameter.
- We still need the BSG interface, which we are working on our side, to get the
  adapter FLASH related read/write operations.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration

[Mike Christie]

On 02/28/2011 12:02 AM, Vikas Chaudhary wrote:
> - We still need the BSG interface, which we are working on our side, to get the
>    adapter FLASH related read/write operations.

So would that be the operations to do something like store/get targets, 
discovery info, isns, chap, iscsi settings like FirstBurst, etc?

RE: [PATCH 0/5]: Proposal for iSCSI Network Configuration

[Vikas Chaudhary]

>-----Original Message-----
>From: Mike Christie [mailto:michaelc@cs.wisc.edu]
>Sent: Monday, February 28, 2011 1:44 PM
>To: Vikas Chaudhary
>Cc: open-iscsi@googlegroups.com; James Bottomley; linux-
>scsi@vger.kernel.org; Lalit Chandivade; Harish Zunjarrao; Manish Rangankar;
>Ravi Anand
>Subject: Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration
>
>On 02/28/2011 12:02 AM, Vikas Chaudhary wrote:
>> - We still need the BSG interface, which we are working on our side, to
>get the
>>    adapter FLASH related read/write operations.
>
>So would that be the operations to do something like store/get targets,
>discovery info, isns, chap, iscsi settings like FirstBurst, etc?

We are planning to add BSG for Vendor specific flash updates like, read/write operations of - NVRAM, firmware and bootcode.

We will use Netlink interface for target discovery info, iscsi settings, login/logout of target.


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration

[Ravi Anand]

On Feb 28, 2011, at 1:34 AM, Vikas Chaudhary wrote:

>> -----Original Message-----
>> From: Mike Christie [mailto:michaelc@cs.wisc.edu]
>> Sent: Monday, February 28, 2011 1:44 PM
>> To: Vikas Chaudhary
>> Cc: open-iscsi@googlegroups.com; James Bottomley; linux-
>> scsi@vger.kernel.org; Lalit Chandivade; Harish Zunjarrao; Manish Rangankar;
>> Ravi Anand
>> Subject: Re: [PATCH 0/5]: Proposal for iSCSI Network Configuration
>>
>> On 02/28/2011 12:02 AM, Vikas Chaudhary wrote:
>>> - We still need the BSG interface, which we are working on our side, to
>> get the
>>>   adapter FLASH related read/write operations.
>>
>> So would that be the operations to do something like store/get targets,
>> discovery info, isns, chap, iscsi settings like FirstBurst, etc?
>
> We are planning to add BSG for Vendor specific flash updates like, read/write operations of - NVRAM, firmware and bootcode.
>
> We will use Netlink interface for target discovery info, iscsi settings, login/logout of target.
>

Basically during last year discussion with you/James/Fujito , two important pieces came out of the discussion :

* Common Generic interface which will work for other H/W offload.
* iscsiadm support for H/W offload, for ex : qla4xxx in this case, so that user can configure
it using Linux native tools.

So after looking into iscsiadm interface and how our API interface works, it seemed much
more logical to use the iscsidam existing interface rather than trying to reinvent the wheel.
The additional work which will be required is to hook up our Application to *Netlink* interface
and iscsiadm will work just by extending the existing infrastrutcure for configuration for ex, which
is a key element for our flash based H/W offload.

As Vikas alluded, BSG will be strictly adhered to just for vendor specific part where we may need to pass
*bigger* blob of data in both directions or updating F/W or NVRAM etc. This is unlike what we intially proposed
for setting up iscsi settings etc using vendor specific bsg interface which was doing it in a opaque manner.

Other discovery element for ex : send target discovery / login/logout etc is being worked on so user can use iscsiadm
native interface.

So we have provided the iscsiadm+iscsi transport+qla4xxx patch for network configuration, to provide the complete overview
the direction we want to go.

Looking forward to comments/feedback to continue this discussion and come to an agreement on how to proceed further.


Thanks
Ravi

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.