From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dimitris Michailidis Subject: Re: [PATCH] cxgb{3,4}*: improve Kconfig dependencies Date: Tue, 01 Mar 2011 01:10:10 -0800 Message-ID: <4D6CB7F2.9020902@chelsio.com> References: <1298950455-4497-1-git-send-email-dm@chelsio.com> <4D6CB26802000078000343BD@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from stargate.chelsio.com ([67.207.112.58]:7695 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755624Ab1CAJPM (ORCPT ); Tue, 1 Mar 2011 04:15:12 -0500 In-Reply-To: <4D6CB26802000078000343BD@vpn.id2.novell.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jan Beulich Cc: linux-scsi@vger.kernel.org, netdev@vger.kernel.org Jan Beulich wrote: >>>> On 01.03.11 at 04:34, Dimitris Michailidis wrote: >> - Remove the dependency of cxgb4 and cxgb4vf on INET. cxgb3 really >> depends on INET, keep it but add it directly to the driver's Kconfig >> entry. >> - Make the iSCSI drivers cxgb3i and cxgb4i available in the SCSI menu >> without requiring any options in the net driver menu to be enabled >> first. Add needed selects so the iSCSI drivers can build their >> corresponding net drivers. >> - Remove CHELSIO_T*_DEPENDS. >> >> Signed-off-by: Dimitris Michailidis >> --- >> drivers/net/Kconfig | 21 +++------------------ >> drivers/scsi/cxgbi/cxgb3i/Kconfig | 4 +++- >> drivers/scsi/cxgbi/cxgb4i/Kconfig | 4 +++- >> 3 files changed, 9 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig >> index f4b3927..6e09d5f 100644 >> --- a/drivers/net/Kconfig >> +++ b/drivers/net/Kconfig >> @@ -2595,14 +2595,9 @@ config CHELSIO_T1_1G >> Enables support for Chelsio's gigabit Ethernet PCI cards. If you >> are using only 10G cards say 'N' here. >> >> -config CHELSIO_T3_DEPENDS >> - tristate >> - depends on PCI && INET >> - default y >> - >> config CHELSIO_T3 >> tristate "Chelsio Communications T3 10Gb Ethernet support" >> - depends on CHELSIO_T3_DEPENDS >> + depends on PCI && INET > > Forgot to remove INET here? Didn't forget it, this driver has a real dependency on INET (ARP more specifically). I mentioned it also in the commit message.