From: Dan Williams <dan.j.williams@intel.com>
To: Greg KH <greg@kroah.com>,
James Bottomley <James.Bottomley@suse.de>,
Kay Sievers <kay.sievers@vrfy.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Nadolski, Edmund" <edmund.nadolski@intel.com>,
"Jiang, Dave" <dave.jiang@intel.com>,
"Skirvin, Jeffrey D" <jeffrey.d.skirvin@intel.com>,
"Danecki, Jacek" <jacek.danecki@intel.com>
Subject: Should isci create its own device class?
Date: Tue, 01 Mar 2011 19:22:39 -0800 [thread overview]
Message-ID: <4D6DB7FF.4090506@intel.com> (raw)
For compatibility with other software raid environments an isci [1]
device may contain up to two controller instances per pci device.
Currently the sysfs path for its scsi_host objects is:
> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/0000:02:08.0/0000:03:00.0/host10/scsi_host/host10
> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/0000:02:08.0/0000:03:00.0/host11/scsi_host/host11
But to reflect reality the pci device is actually the parent of two
independent controller instances. With a mockup like:
> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/0000:02:08.0/0000:03:00.0/controller0/host10/scsi_host/host10
> ../../devices/pci0000:00/0000:00:01.0/0000:01:00.0/0000:02:08.0/0000:03:00.0/controller1/host11/scsi_host/host11
I can see this being beneficial in a few ways:
1/ fix dev_printk() messages which right now give an ambiguous "isci
0000:03:00.0" prefix
2/ controller boundaries are visible via the sysfs path without need to
to look at sas_addresses to determine the controller.
2/ if we ever wanted to support some per controller attributes between
the global pci attributes and the scsi_host attributes.
...but would this confuse /dev/disk/by-path/ or any other unintended
side effects?
--
Dan
[1]: http://marc.info/?l=linux-scsi&m=129703780424729&w=2
next reply other threads:[~2011-03-02 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 3:22 Dan Williams [this message]
2011-03-02 12:49 ` Should isci create its own device class? James Bottomley
2011-03-02 18:38 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6DB7FF.4090506@intel.com \
--to=dan.j.williams@intel.com \
--cc=James.Bottomley@suse.de \
--cc=dave.jiang@intel.com \
--cc=edmund.nadolski@intel.com \
--cc=greg@kroah.com \
--cc=jacek.danecki@intel.com \
--cc=jeffrey.d.skirvin@intel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox